[GitHub] spark pull request: [SPARK-5360] [SPARK-6606] Eliminate duplicate ...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4145#discussion_r27852064
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala ---
    @@ -29,15 +29,16 @@ import org.apache.spark.annotation.DeveloperApi
     import org.apache.spark.util.collection.{ExternalAppendOnlyMap, AppendOnlyMap, CompactBuffer}
     import org.apache.spark.util.Utils
     import org.apache.spark.serializer.Serializer
    -import org.apache.spark.shuffle.ShuffleHandle
    -
    -private[spark] sealed trait CoGroupSplitDep extends Serializable
     
    +/** The references to rdd and splitIndex are transient because redundant information is stored
    +  * in the CoGroupedRDD object.  Because CoGroupedRDD is serialized separately from
    +  * CoGrpupPartition, if rdd and splitIndex aren't transient, they'll be included twice in the
    --- End diff --
    
    nit pick CoGroupPartition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org