You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2006/07/06 11:02:41 UTC
Re: svn commit: r419251 - /perl/Apache-SizeLimit/trunk/Makefile.PL
autarch@apache.org wrote:
> -sub MY::postamble {
> +package MY;
> +
> +sub postamble {
> my $self = shift;
> -sub MY::test {
> +sub test {
> -sub MY::clean {
> +sub clean {
While that works, Its not consistent with any of our other Makefile.PL's do we want to be consistent, or does it not
matter ?
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r419251 - /perl/Apache-SizeLimit/trunk/Makefile.PL
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Dave Rolsky wrote:
> I can't call SUPER:: without having the code be in a defined package.
> I'd prefer to have it call SUPER:: rather than hard-coding a particular
> package, it's just cleaner.
Okay, I'm sold.
--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r419251 - /perl/Apache-SizeLimit/trunk/Makefile.PL
Posted by Dave Rolsky <au...@urth.org>.
On Thu, 6 Jul 2006, Philip M. Gollucci wrote:
> autarch@apache.org wrote:
>> -sub MY::postamble {
>> +package MY;
>> +
>> +sub postamble {
>> my $self = shift;
>> -sub MY::test {
>> +sub test {
>> -sub MY::clean {
>> +sub clean {
>
> While that works, Its not consistent with any of our other Makefile.PL's do we want to be consistent, or does it not
> matter ?
I can't call SUPER:: without having the code be in a defined package. I'd
prefer to have it call SUPER:: rather than hard-coding a particular
package, it's just cleaner.
-dave
/*===================================================
VegGuide.Org www.BookIRead.com
Your guide to all that's veg. My book blog
===================================================*/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org