You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/28 08:15:51 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #7403: [WIP] #5791: Address errors found by lgtm.com

codecov-io edited a comment on issue #7403: [WIP] #5791: Address errors found by lgtm.com
URL: https://github.com/apache/incubator-superset/pull/7403#issuecomment-488669768
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=h1) Report
   > Merging [#7403](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f7d3413a501d8b643318fe7c0641eba608a079f5?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7403/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7403      +/-   ##
   ==========================================
   - Coverage   65.26%   65.23%   -0.03%     
   ==========================================
     Files         435      435              
     Lines       21485    21481       -4     
     Branches     2379     2378       -1     
   ==========================================
   - Hits        14023    14014       -9     
   - Misses       7342     7347       +5     
     Partials      120      120
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `76.72% <ø> (ø)` | :arrow_up: |
   | [superset/data/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9lbmVyZ3kucHk=) | `100% <ø> (ø)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `66.66% <ø> (+0.45%)` | :arrow_up: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.43% <100%> (+0.04%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.15% <100%> (-0.07%)` | :arrow_down: |
   | [superset/stats\_logger.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3RhdHNfbG9nZ2VyLnB5) | `75% <100%> (+0.58%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.29% <100%> (+0.4%)` | :arrow_up: |
   | [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `36.53% <0%> (-3.89%)` | :arrow_down: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `61.47% <0%> (-0.88%)` | :arrow_down: |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `67.58% <0%> (-0.66%)` | :arrow_down: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/7403/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=footer). Last update [f7d3413...09abd5c](https://codecov.io/gh/apache/incubator-superset/pull/7403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org