[GitHub] iilyak commented on a change in pull request #474: 3364 fix view compactor unknown info

[gi...@git.apache.org]

iilyak commented on a change in pull request #474: 3364 fix view compactor unknown info
URL: https://github.com/apache/couchdb/pull/474#discussion_r110984344
 
 

 ##########
 File path: src/couch_index/src/couch_index_compactor.erl
 ##########
 @@ -81,6 +85,14 @@ handle_cast(_Mesg, State) ->
 
 handle_info({'EXIT', Pid, normal}, #st{pid=Pid}=State) ->
     {noreply, State#st{pid=undefined}};
+handle_info({'EXIT', Pid, Reason}, #st{pid = Pid} = State) ->
+    #st{idx = Idx, mod = Mod} = State,
+    {ok, IdxState} = gen_server:call(Idx, {compaction_failed, Reason}),
 
 Review comment:
   I think the following would be better. Since it would allow us to hide the internal representation. 
   `{ok, IdxState} = couch_index:handle_failure(Pid, Reason)`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services