You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/06 15:57:45 UTC

[GitHub] [airflow] Mrngilles opened a new pull request #18776: Allow disabling the Helm hooks in the helm chart

Mrngilles opened a new pull request #18776:
URL: https://github.com/apache/airflow/pull/18776


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Following #17447, I added a way to disable the Helm hooks so that the jobs are properly created in ArgoCD.
   
   This does not change the default behavior of the helm chart, but makes it more flexible
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936581354


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-970729476


   Thanks @kylegalea, I see that it isn't in there, but it should have been. Let me investigate further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019880


   Thanks for the contribution @Mrngilles! Congrats on your first commit πŸŽ‰


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936621680


   Can you add docs about this option to [docs/helm-chart](https://github.com/apache/airflow/tree/main/docs/helm-chart)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019284


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham merged pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #18776:
URL: https://github.com/apache/airflow/pull/18776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019284


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham merged pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #18776:
URL: https://github.com/apache/airflow/pull/18776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962030635


   Cool!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Mrngilles commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
Mrngilles commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-937510669


   Sure, I'll get that done. Thanks for the review 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham merged pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #18776:
URL: https://github.com/apache/airflow/pull/18776


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Mrngilles commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
Mrngilles commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-937728295


   Added tests and documentation. Let me know if you want me to add more of those


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936557165


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019880


   Thanks for the contribution @Mrngilles! Congrats on your first commit πŸŽ‰


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019284


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962030635


   Cool!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-970846009


   @kylegalea, thanks for bringing this up! Sorry I accidentally messed up getting this into 1.3.0. It'll _definitely_ make it into 1.4.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962019880


   Thanks for the contribution @Mrngilles! Congrats on your first commit πŸŽ‰


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-962030635


   Cool!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Mrngilles commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
Mrngilles commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-937510669






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kylegalea commented on pull request #18776: Allow disabling the Helm hooks in the helm chart

Posted by GitBox <gi...@apache.org>.
kylegalea commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-970087536


   this change  should have been added to 1.3.0 but is not there


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org