You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/06/20 06:43:48 UTC
[GitHub] [incubator-teaclave] renxingliang opened a new pull request #365: Fix the problem that leveldb parses log file abnormally
renxingliang opened a new pull request #365:
URL: https://github.com/apache/incubator-teaclave/pull/365
## Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [ ] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] m4sterchain commented on pull request #365: Fix the problem that leveldb parses log file abnormally
Posted by GitBox <gi...@apache.org>.
m4sterchain commented on pull request #365:
URL: https://github.com/apache/incubator-teaclave/pull/365#issuecomment-647279455
Hi @renxingliang ，thanks for the information. I think this issue is fixed by #225. Could you please help confirm it still exists? If so, it's better to add a test case for the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on pull request #365: Fix the problem that leveldb parses log file abnormally
Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #365:
URL: https://github.com/apache/incubator-teaclave/pull/365#issuecomment-647242956
I'm okay with the change. @renxingliang, maybe next time, you can explain a little bit in the PR (follow the template information).
@m4sterchain, please help to confirm this PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] renxingliang closed pull request #365: Fix the problem that leveldb parses log file abnormally
Posted by GitBox <gi...@apache.org>.
renxingliang closed pull request #365:
URL: https://github.com/apache/incubator-teaclave/pull/365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org