You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/07/25 06:24:14 UTC
[GitHub] [hadoop] virajjasani commented on a change in pull request #3226: HDFS-16137.Improve the comments related to FairCallQueue#queues.
virajjasani commented on a change in pull request #3226:
URL: https://github.com/apache/hadoop/pull/3226#discussion_r676091486
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
##########
@@ -58,7 +58,10 @@
public static final Logger LOG = LoggerFactory.getLogger(FairCallQueue.class);
- /* The queues */
+ /*
+ * Save the queue data of multiple priority strategies.
+ * Usually the number of queue data and priority strategies saved is the same.
+ * */
private final ArrayList<BlockingQueue<E>> queues;
Review comment:
Also, good to convert this to `private final List<BlockingQueue<E>> queues` if you would like to consider as part of this PR.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
##########
@@ -58,7 +58,10 @@
public static final Logger LOG = LoggerFactory.getLogger(FairCallQueue.class);
- /* The queues */
+ /*
+ * Save the queue data of multiple priority strategies.
+ * Usually the number of queue data and priority strategies saved is the same.
+ * */
Review comment:
nit: minor change and alignment of comment section:
```
/**
* Save the queue data of multiple priority strategies as list of blocking queues.
* Usually the number of queue data and priority strategies saved is the same.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org