You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/25 15:40:57 UTC
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #147: IGNITE-14567
AMashenkov commented on a change in pull request #147:
URL: https://github.com/apache/ignite-3/pull/147#discussion_r638919832
##########
File path: modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageListener.java
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.metastorage.server.raft;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Consumer;
+import org.apache.ignite.internal.metastorage.common.ConditionType;
+import org.apache.ignite.internal.metastorage.common.command.ConditionInfo;
+import org.apache.ignite.internal.metastorage.common.command.GetAllCommand;
+import org.apache.ignite.internal.metastorage.common.command.GetAndPutAllCommand;
+import org.apache.ignite.internal.metastorage.common.command.GetAndPutCommand;
+import org.apache.ignite.internal.metastorage.common.command.GetAndRemoveAllCommand;
+import org.apache.ignite.internal.metastorage.common.command.GetAndRemoveCommand;
+import org.apache.ignite.internal.metastorage.common.command.GetCommand;
+import org.apache.ignite.internal.metastorage.common.command.InvokeCommand;
+import org.apache.ignite.internal.metastorage.common.command.MultipleEntryResponse;
+import org.apache.ignite.internal.metastorage.common.command.OperationInfo;
+import org.apache.ignite.internal.metastorage.common.command.PutAllCommand;
+import org.apache.ignite.internal.metastorage.common.command.PutCommand;
+import org.apache.ignite.internal.metastorage.common.command.RangeCommand;
+import org.apache.ignite.internal.metastorage.common.command.RemoveAllCommand;
+import org.apache.ignite.internal.metastorage.common.command.RemoveCommand;
+import org.apache.ignite.internal.metastorage.common.command.SingleEntryResponse;
+import org.apache.ignite.internal.metastorage.common.command.WatchExactKeysCommand;
+import org.apache.ignite.internal.metastorage.common.command.WatchRangeKeysCommand;
+import org.apache.ignite.internal.metastorage.common.command.cursor.CursorCloseCommand;
+import org.apache.ignite.internal.metastorage.common.command.cursor.CursorHasNextCommand;
+import org.apache.ignite.internal.metastorage.common.command.cursor.CursorNextCommand;
+import org.apache.ignite.internal.metastorage.server.Condition;
+import org.apache.ignite.internal.metastorage.server.Entry;
+import org.apache.ignite.internal.metastorage.server.EntryEvent;
+import org.apache.ignite.internal.metastorage.server.ExistenceCondition;
+import org.apache.ignite.internal.metastorage.server.KeyValueStorage;
+import org.apache.ignite.internal.metastorage.server.Operation;
+import org.apache.ignite.internal.metastorage.server.RevisionCondition;
+import org.apache.ignite.internal.metastorage.server.ValueCondition;
+import org.apache.ignite.internal.metastorage.server.WatchEvent;
+import org.apache.ignite.internal.util.Cursor;
+import org.apache.ignite.lang.IgniteBiTuple;
+import org.apache.ignite.lang.IgniteInternalException;
+import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.raft.client.ReadCommand;
+import org.apache.ignite.raft.client.WriteCommand;
+import org.apache.ignite.raft.client.service.CommandClosure;
+import org.apache.ignite.raft.client.service.RaftGroupListener;
+
+/**
+ * Meta storage listener.
+ * TODO: IGNITE-14693 Implement Meta storage exception handling logic.
+ */
+public class MetaStorageListener implements RaftGroupListener {
+ /** Storage. */
+ private final KeyValueStorage storage;
+
+ /** Cursors map. */
+ private final Map<IgniteUuid, IgniteBiTuple<Cursor<?>, CursorType>> cursors;
+
+ /**
+ * @param storage Storage.
+ */
+ public MetaStorageListener(KeyValueStorage storage) {
+ this.storage = storage;
+ this.cursors = new ConcurrentHashMap<>();
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onRead(Iterator<CommandClosure<ReadCommand>> iter) {
+ while (iter.hasNext()) {
+ CommandClosure<ReadCommand> clo = iter.next();
+
+ if (clo.command() instanceof GetCommand) {
+ GetCommand getCmd = (GetCommand) clo.command();
+
+ Entry e;
+
+ if (getCmd.revision() != 0)
+ e = storage.get(getCmd.key(), getCmd.revision());
+ else
+ e = storage.get(getCmd.key());
+
+ SingleEntryResponse resp = new SingleEntryResponse(
+ e.key(), e.value(), e.revision(), e.updateCounter()
+ );
+
+ clo.result(resp);
+ }
+ else if (clo.command() instanceof GetAllCommand) {
+ GetAllCommand getAllCmd = (GetAllCommand) clo.command();
+
+ Collection<Entry> entries;
+
+ if (getAllCmd.revision() != 0)
+ entries = storage.getAll(getAllCmd.keys(), getAllCmd.revision());
+ else
+ entries = storage.getAll(getAllCmd.keys());
+
+ List<SingleEntryResponse> res = new ArrayList<>(entries.size());
+
+ for (Entry e : entries)
+ res.add(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+
+ clo.result(new MultipleEntryResponse(res));
+ }
+ else if (clo.command() instanceof CursorHasNextCommand) {
+ CursorHasNextCommand cursorHasNextCmd = (CursorHasNextCommand) clo.command();
+
+ assert cursors.containsKey(cursorHasNextCmd.cursorId());
+
+ clo.result(cursors.get(cursorHasNextCmd.cursorId()).getKey().hasNext());
+ }
+ else
+ assert false : "Command was not found [cmd=" + clo.command() + ']';
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onWrite(Iterator<CommandClosure<WriteCommand>> iter) {
+ while (iter.hasNext()) {
+ CommandClosure<WriteCommand> clo = iter.next();
+
+ if (clo.command() instanceof PutCommand) {
+ PutCommand putCmd = (PutCommand) clo.command();
+
+ storage.put(putCmd.key(), putCmd.value());
+
+ clo.result(null);
+ }
+ else if (clo.command() instanceof GetAndPutCommand) {
+ GetAndPutCommand getAndPutCmd = (GetAndPutCommand) clo.command();
+
+ Entry e = storage.getAndPut(getAndPutCmd.key(), getAndPutCmd.value());
+
+ clo.result(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+ }
+ else if (clo.command() instanceof PutAllCommand) {
+ PutAllCommand putAllCmd = (PutAllCommand) clo.command();
+
+ storage.putAll(putAllCmd.keys(), putAllCmd.values());
+
+ clo.result(null);
+ }
+ else if (clo.command() instanceof GetAndPutAllCommand) {
+ GetAndPutAllCommand getAndPutAllCmd = (GetAndPutAllCommand) clo.command();
+
+ Collection<Entry> entries = storage.getAndPutAll(getAndPutAllCmd.keys(), getAndPutAllCmd.vals());
+
+ List<SingleEntryResponse> resp = new ArrayList<>(entries.size());
+
+ for (Entry e : entries)
+ resp.add(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+
+ clo.result(new MultipleEntryResponse(resp));
+ }
+ else if (clo.command() instanceof RemoveCommand) {
+ RemoveCommand rmvCmd = (RemoveCommand) clo.command();
+
+ storage.remove(rmvCmd.key());
+
+ clo.result(null);
+ }
+ else if (clo.command() instanceof GetAndRemoveCommand) {
+ GetAndRemoveCommand getAndRmvCmd = (GetAndRemoveCommand) clo.command();
+
+ Entry e = storage.getAndRemove(getAndRmvCmd.key());
+
+ clo.result(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+ }
+ else if (clo.command() instanceof RemoveAllCommand) {
+ RemoveAllCommand rmvAllCmd = (RemoveAllCommand) clo.command();
+
+ storage.removeAll(rmvAllCmd.keys());
+
+ clo.result(null);
+ }
+ else if (clo.command() instanceof GetAndRemoveAllCommand) {
+ GetAndRemoveAllCommand getAndRmvAllCmd = (GetAndRemoveAllCommand) clo.command();
+
+ Collection<Entry> entries = storage.getAndRemoveAll(getAndRmvAllCmd.keys());
+
+ List<SingleEntryResponse> resp = new ArrayList<>(entries.size());
+
+ for (Entry e : entries)
+ resp.add(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+
+ clo.result(new MultipleEntryResponse(resp));
+ }
+ else if (clo.command() instanceof InvokeCommand) {
+ InvokeCommand cmd = (InvokeCommand) clo.command();
+
+ boolean res = storage.invoke(
+ toCondition(cmd.condition()),
+ toOperations(cmd.success()),
+ toOperations(cmd.failure())
+ );
+
+ clo.result(res);
+ }
+ else if (clo.command() instanceof RangeCommand) {
+ RangeCommand rangeCmd = (RangeCommand) clo.command();
+
+ IgniteUuid cursorId = new IgniteUuid(UUID.randomUUID(), 0L);
+
+ Cursor<Entry> cursor = storage.range(
+ rangeCmd.keyFrom(),
+ rangeCmd.keyTo(),
+ rangeCmd.revUpperBound()
+ );
+
+ cursors.put(cursorId, new IgniteBiTuple<>(cursor, CursorType.RANGE));
+
+ clo.result(cursorId);
+ }
+ else if (clo.command() instanceof CursorNextCommand) {
+ CursorNextCommand cursorNextCmd = (CursorNextCommand) clo.command();
+
+ assert cursors.containsKey(cursorNextCmd.cursorId());
+
+ IgniteBiTuple<Cursor<?>, CursorType> cursorDesc = cursors.get(cursorNextCmd.cursorId());
+
+ if (cursorDesc.getValue() == CursorType.RANGE) {
+ Entry e = (Entry) cursorDesc.getKey().next();
+
+ clo.result(new SingleEntryResponse(e.key(), e.value(), e.revision(), e.updateCounter()));
+ }
+ else if (cursorDesc.getValue() == CursorType.WATCH) {
+ WatchEvent evt = (WatchEvent) cursorDesc.getKey().next();
+
+ List<SingleEntryResponse> resp = new ArrayList<>(evt.entryEvents().size() * 2);
+
+ for (EntryEvent e : evt.entryEvents()) {
+ Entry o = e.oldEntry();
+
+ Entry n = e.entry();
+
+ resp.add(new SingleEntryResponse(o.key(), o.value(), o.revision(), o.updateCounter()));
+
+ resp.add(new SingleEntryResponse(n.key(), n.value(), n.revision(), n.updateCounter()));
+ }
+
+ clo.result(new MultipleEntryResponse(resp));
+ }
+ }
+ else if (clo.command() instanceof CursorCloseCommand) {
+ CursorCloseCommand cursorCloseCmd = (CursorCloseCommand) clo.command();
+
+ IgniteBiTuple<Cursor<?>, CursorType> val = cursors.get(cursorCloseCmd.cursorId());
+
+ if (val == null) {
+ clo.result(null);
+
+ return;
+ }
+
+ try {
+ val.getKey().close();
+ }
+ catch (Exception e) {
+ throw new IgniteInternalException(e);
+ }
+
+ clo.result(null);
+ }
+ else if (clo.command() instanceof WatchRangeKeysCommand) {
+ WatchRangeKeysCommand watchCmd = (WatchRangeKeysCommand) clo.command();
+
+ IgniteUuid cursorId = new IgniteUuid(UUID.randomUUID(), 0L);
+
+ Cursor<WatchEvent> cursor =
+ storage.watch(watchCmd.keyFrom(), watchCmd.keyTo(), watchCmd.revision());
+
+ cursors.put(cursorId, new IgniteBiTuple<>(cursor, CursorType.WATCH));
+
+ clo.result(cursorId);
+ }
+ else if (clo.command() instanceof WatchExactKeysCommand) {
+ WatchExactKeysCommand watchCmd = (WatchExactKeysCommand) clo.command();
+
+ IgniteUuid cursorId = new IgniteUuid(UUID.randomUUID(), 0L);
+
+ Cursor<WatchEvent> cursor = storage.watch(watchCmd.keys(), watchCmd.revision());
+
+ cursors.put(cursorId, new IgniteBiTuple<>(cursor, CursorType.WATCH));
+
+ clo.result(cursorId);
+ }
+ else
+ assert false : "Command was not found [cmd=" + clo.command() + ']';
+ }
+ }
+
+ /** {@inheritDoc} */
+ @Override public void onSnapshotSave(String path, Consumer<Throwable> doneClo) {
+ // Not implemented yet.
+ }
+
+ /** {@inheritDoc} */
+ @Override public boolean onSnapshotLoad(String path) {
+ // Not implemented yet.
+ return false;
+ }
+
+ /** */
+ private static Condition toCondition(ConditionInfo info) {
+ byte[] key = info.key();
+
+ ConditionType type = info.type();
+
+ if (type == ConditionType.KEY_EXISTS)
Review comment:
`Switch(type)` construction will be more natural and more effective here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org