[jira] Commented: (DERBY-1014) Make tests less sensitive to pre-fetching

["Knut Anders Hatlen (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-1014?page=comments#action_12370687 ] 

Knut Anders Hatlen commented on DERBY-1014:
-------------------------------------------

I plan to commit this patch next week if I don't get any comments.

> Make tests less sensitive to pre-fetching
> -----------------------------------------
>
>          Key: DERBY-1014
>          URL: http://issues.apache.org/jira/browse/DERBY-1014
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Reporter: Knut Anders Hatlen
>     Assignee: Knut Anders Hatlen
>     Priority: Minor
>  Attachments: DERBY-1014-v1.diff, DERBY-1014-v1.stat
>
> Some tests are very sensitive to changes in pre-fetching, either
> because they call SYSCS_UTIL.SYSCS_GET_RUNTIMESTATISTICS() which
> displays the number of rows seen, or because a failure that normally
> is exposed when calling ResultSet.next() is exposed when calling
> Statement.execute().
> Most of these tests are not testing when or how much data is
> pre-fetched. If we make the tests less sensitive to pre-fetching, it
> is easier to catch the real regressions when changing the way Derby is
> pre-fetching data. Also, patches in that area of the code will be
> smaller (fewer test changes) and easier to review.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Re: [jira] Commented: (DERBY-1014) Make tests less sensitive to pre-fetching

[Bryan Pendleton <bp...@amberpoint.com>]

>> Bryan, as far as I have understood, this JIRA is not about the actual
>> pre-fetching, but about fixing the tests so that they are not broken
>> when prefetching is introduced.  Prefetching is covered by DERBY-822.

Thanks! I knew this once, but had forgotten.

I'm still quite interested in the whole pre-fetching topic, and I suspect
I may learn quite a bit by studying the tests, as it's interesting to me
to consider how the external behavior of the system, as reflected in the
tests, is changed via the pre-fetching. So seeing where the prefetching
changes interacted with tests which proved sensitive to prefetching, is
an interesting eye into this new behavior.

Plus I need to learn more about the tests in general, so taking the
opportunity to study patches to them is good exercise.

But I've been quite busy with some other issues recently, so please don't
hold up this issue on my behalf. I'll continue to follow it as you go.

thanks,

bryan

Re: [jira] Commented: (DERBY-1014) Make tests less sensitive to pre-fetching

[Knut Anders Hatlen <Kn...@Sun.COM>]

Øystein Grøvlen <Oy...@Sun.COM> writes:

> Bryan, as far as I have understood, this JIRA is not about the actual
> pre-fetching, but about fixing the tests so that they are not broken
> when prefetching is introduced.  Prefetching is covered by DERBY-822.

That's correct. I posted a patch for DERBY-822, but the updating of
canons made the patch so big that I was advised to make the test
changes independent of the code changes. I wanted to wait before
committing the test changes so that the community got the chance to
have a look at the patch and tell me if the changes would remove
output that was relevant for the tests.

When the test patch is committed I will submit a new and much smaller
patch for DERBY-822.

> --
> Øystein
>
> Bryan Pendleton wrote:
>> Knut Anders Hatlen (JIRA) wrote:
>> 
>>>     [
>>> http://issues.apache.org/jira/browse/DERBY-1014?page=comments#action_12370687
>>> ]
>>> I plan to commit this patch next week if I don't get any comments.
>> I started looking at this patch when you first posted it, but got
>> distracted by a few other issues.
>> What I saw looked good, though.
>> I would like to understand the pre-fetching behaviors better, so I
>> do
>> intend to look at your changes some more.
>> But I don't think you should delay your commit on my behalf; any
>> questions
>> I have can be resolved post-commit.
>> thanks,
>> bryan
>> 

-- 
Knut Anders

Re: [jira] Commented: (DERBY-1014) Make tests less sensitive to pre-fetching

[Øystein Grøvlen <Oy...@Sun.COM>]

Bryan, as far as I have understood, this JIRA is not about the actual 
pre-fetching, but about fixing the tests so that they are not broken 
when prefetching is introduced.  Prefetching is covered by DERBY-822.

--
Øystein

Bryan Pendleton wrote:
> Knut Anders Hatlen (JIRA) wrote:
> 
>>     [ 
>> http://issues.apache.org/jira/browse/DERBY-1014?page=comments#action_12370687 
>> ]
>> I plan to commit this patch next week if I don't get any comments.
> 
> 
> I started looking at this patch when you first posted it, but got
> distracted by a few other issues.
> 
> What I saw looked good, though.
> 
> I would like to understand the pre-fetching behaviors better, so I do
> intend to look at your changes some more.
> 
> But I don't think you should delay your commit on my behalf; any questions
> I have can be resolved post-commit.
> 
> thanks,
> 
> bryan
> 

Re: [jira] Commented: (DERBY-1014) Make tests less sensitive to pre-fetching

[Bryan Pendleton <bp...@amberpoint.com>]

Knut Anders Hatlen (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/DERBY-1014?page=comments#action_12370687 ] 
> 
> I plan to commit this patch next week if I don't get any comments.

I started looking at this patch when you first posted it, but got
distracted by a few other issues.

What I saw looked good, though.

I would like to understand the pre-fetching behaviors better, so I do
intend to look at your changes some more.

But I don't think you should delay your commit on my behalf; any questions
I have can be resolved post-commit.

thanks,

bryan