You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/01/07 22:16:06 UTC
Review Request 29671: Support select distinct *
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs
-----
itests/src/test/resources/testconfiguration.properties 5d07fba
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67558
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
<https://reviews.apache.org/r/29671/#comment111596>
Why do we need Select here since all you are looking for is column names to build ast, can't you get that from srcRel.
- John Pullokkaran
On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 9:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 5d07fba
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67559
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
<https://reviews.apache.org/r/29671/#comment111597>
Fix spacing
- John Pullokkaran
On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 9:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 5d07fba
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67562
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
<https://reviews.apache.org/r/29671/#comment111599>
You can get RR from relToHiveRR map; i don't think you need this aditional arg.
- John Pullokkaran
On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 9:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 5d07fba
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review68137
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On Jan. 13, 2015, 6:07 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 6:07 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 917b3a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 6:07 p.m.)
Review request for hive and John Pullokkaran.
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 917b3a4
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 6:04 p.m.)
Review request for hive and John Pullokkaran.
Changes
-------
remove spaces
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 917b3a4
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 3:48 a.m.)
Review request for hive and John Pullokkaran.
Changes
-------
address john's comments.
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 917b3a4
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67784
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/29671/#comment111855>
The logic that builds AST is the same for CBO & non CBO path. why don't we pull it out put it in its own method.
- John Pullokkaran
On Jan. 13, 2015, 12:31 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 12:31 a.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 917b3a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67783
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/29671/#comment111854>
Why do we need to pass in out put row resolver?
- John Pullokkaran
On Jan. 13, 2015, 12:31 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 12:31 a.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 917b3a4
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
> ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
> ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 12:31 a.m.)
Review request for hive and John Pullokkaran.
Changes
-------
rebase after spark is merged
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 917b3a4
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cea86df
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/
-----------------------------------------------------------
(Updated Jan. 10, 2015, 4:02 a.m.)
Review request for hive and John Pullokkaran.
Changes
-------
Address John's comments. (1) add more test cases including both pos and neg tests. (2) remove spaces in code.
Repository: hive-git
Description
-------
Support select distinct * in operator genaration phase.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 68e9b7d
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3534551
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 971910a
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
ql/src/test/queries/clientnegative/selectDistinctStarNeg_1.q PRE-CREATION
ql/src/test/queries/clientnegative/selectDistinctStarNeg_2.q PRE-CREATION
ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_1.q.out PRE-CREATION
ql/src/test/results/clientnegative/selectDistinctStarNeg_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/29671/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67560
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
<https://reviews.apache.org/r/29671/#comment111598>
Fix Spacing
- John Pullokkaran
On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 9:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 5d07fba
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 29671: Support select distinct *
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29671/#review67566
-----------------------------------------------------------
ql/src/test/queries/clientpositive/selectDistinctStar.q
<https://reviews.apache.org/r/29671/#comment111603>
Add more test cases to cover more operators:
ex:
1. select distinct * from src union all select distinct * from src1
2. select distinct * from src join src1 on src.key=src1.key
3. select * from (select distinct * from src)src1 join (select distinct * from src)src2 on src1.key=src2.key
Also could you add tests to negative test driver
- John Pullokkaran
On Jan. 7, 2015, 9:16 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29671/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 9:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support select distinct * in operator genaration phase.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 5d07fba
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 306edf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c2d5c8c
> ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 57868b7
> ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 9ad6714
> ql/src/test/queries/clientpositive/selectDistinctStar.q PRE-CREATION
> ql/src/test/results/clientpositive/selectDistinctStar.q.out PRE-CREATION
> ql/src/test/results/clientpositive/tez/selectDistinctStar.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29671/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>