[GitHub] flink issue #4564: [FLINK-7442] Add option for using child-first classloader...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4564
  
    Thanks, this looks better to me!
    
    I would suggest to not pass the configuration into the library cache manager.
    I think passing configuration objects into specialized / dedicated components is an anti-pattern. It makes testing complicated, signatures inexplicit, etc.
    
    For the second task of the classloader, loading resources: Do we have a test that validates the resource resolution? I think this passes the tests of the previous pull request because it behaves for resources like a *parent-first classloader*, which seems inconsistent. Admittedly the existing implementation of the child-first classloader was for resources a child-only classloader, which was also not correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---