You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/09 11:19:58 UTC
[GitHub] [iotdb] ericpai opened a new pull request #2789: Add generated-sources as source folder
ericpai opened a new pull request #2789:
URL: https://github.com/apache/iotdb/pull/2789
## Description
The generated source files in `thirft/target/generated-sources` can't be auto discovered by IDEs like VSCode and IntelliJ IDEA.
In IDEA, we can solve this by following the instructions in https://iotdb.apache.org/Development/ContributeGuide.html#_2-iotdb-debugging-method.
However, this can't be applied in VSCode Java plugin because adding a folder to Java source path is forbidden in a maven project. The error output is `Unsupported operation. Please use pom.xml file to manage the source directories of maven project.`.
### Solution
Use `build-helper-maven-plugin` to add the folder to sources in `generate-sources` phase.
Influenced modules:
- antlr
- thrift
If this PR is accepted, I will submit another one to update the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 merged pull request #2789: [IOTDB-1198] Add generated-sources as source folder
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2789:
URL: https://github.com/apache/iotdb/pull/2789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org