You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/10/10 05:19:55 UTC
[GitHub] storm pull request #1728: STORM-2142 ReportErrorAndDie runs suicide function...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1728
STORM-2142 ReportErrorAndDie runs suicide function only when InterruptedException or InterruptedIOException is thrown
* There seems to be a small bug while porting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2142
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1728
----
commit df67ade7ef58707c3142853eb1010283e730d78f
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-10-10T05:18:14Z
STORM-2142 ReportErrorAndDie runs suicide function only when InterruptedException or InterruptedIOException is thrown
* There seems to be a small bug while porting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1728
+1
Looks like mistranslation. This restores the behavior of the old Clojure code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1728
(Nice catch, BTW)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1728: STORM-2142 ReportErrorAndDie runs suicide function only w...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1728
@knusbaum Thanks for the review. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1728: STORM-2142 ReportErrorAndDie runs suicide function...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---