[GitHub] [zeppelin] zjffdu commented on a change in pull request #4293: [ZEPPELIN-5639] Support node label in yarn interpreter launcher

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #4293:
URL: https://github.com/apache/zeppelin/pull/4293#discussion_r794986734



##########
File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##########
@@ -178,6 +178,10 @@ public void start(String userName) throws IOException {
       this.appId = appResponse.getApplicationId();
       ApplicationSubmissionContext appContext = yarnApplication.getApplicationSubmissionContext();
       appContext = createApplicationSubmissionContext(appContext);
+      String YARN_NODE_LABEL_EXPRESSION = "yarn.node.label.expression";

Review comment:
       It is better to name it as `zeppelin.interpreter.yarn.node.label.expression` to make it consistent with memory and core configuration (`zeppelin.interpreter.yarn.resource.memory` & `zeppelin.interpreter.yarn.resource.cores`).
   
   Besides that, the document also needs to be updated. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org