[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #5130: Allow setting Zookeeper SPN using Kyuubi configuration

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on code in PR #5130:
URL: https://github.com/apache/kyuubi/pull/5130#discussion_r1282659218


##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperClientProvider.scala:
##########
@@ -108,7 +108,10 @@ object ZookeeperClientProvider extends Logging {
           throw new IOException(s"${HA_ZK_AUTH_KEYTAB.key}: $keytab does not exists")
         }
         System.setProperty("zookeeper.sasl.clientconfig", "KyuubiZooKeeperClient")
-        val serverPrincipal = KyuubiHadoopUtils.getServerPrincipal(principal)
+        conf.get(HA_ZK_AUTH_SERVER_PRINCIPAL).foreach { zkServerPrincipal =>
+          System.setProperty("zookeeper.server.principal", zkServerPrincipal)

Review Comment:
   ZOOKEEPER-1467: Make server principal configurable at client side.
   
   https://issues.apache.org/jira/browse/ZOOKEEPER-1467
   
   Fix Version/s: 3.6.0, 3.5.7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org