You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/19 14:13:12 UTC

[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #591: Don't check position of comments right of code when separated by prep…

johannes-nivus opened a new pull request #591: Don't check position of comments right of code when separated by prep…
URL: https://github.com/apache/incubator-nuttx/pull/591
 
 
   …rocessor line without comment.
   Please see #585 
   It allows imxrt_usbotg.h:275
   ```
   #define USBDEV_USBCMD_ITC_SHIFT              (16)      /* Bits 16-23: Interrupt threshold control */
   #define USBDEV_USBCMD_ITC_MASK               (255 << USBDEV_USBCMD_ITC_SHIFT)
   #  define USBDEV_USBCMD_ITCIMME              (0  << USBDEV_USBCMD_ITC_SHIFT) /* Immediate (no threshold) */
   ```
   but not imxrt_usbotg.h:284
   ```
   #  define USBDEV_USBCMD_ITC32UF              (32 << USBDEV_USBCMD_ITC_SHIFT) /* 32 micro frames */
   #  define USBDEV_USBCMD_ITC64UF              (64 << USBDEV_USBCMD_ITC_SHIFT) /* 64 micro frames */
   #define USBDEV_USBCMD_ATDTW                  (1 << 14) /* Bit 14: Add dTD trip wire */
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #591: Don't check position of comments right of code when separated by prep…

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #591: Don't check position of comments right of code when separated by prep…
URL: https://github.com/apache/incubator-nuttx/pull/591
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #591: Don't check position of comments right of code when separated by prep…

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #591: Don't check position of comments right of code when separated by prep…
URL: https://github.com/apache/incubator-nuttx/pull/591#issuecomment-601276968
 
 
   @johannes-nivus with your role (credentials) can you see the button?
   ![image](https://user-images.githubusercontent.com/1945821/77089892-a4a46d80-69c3-11ea-8806-137c5cb39d14.png)
   
   I will add him.....
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #591: Don't check position of comments right of code when separated by prep…

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #591: Don't check position of comments right of code when separated by prep…
URL: https://github.com/apache/incubator-nuttx/pull/591#issuecomment-601283207
 
 
   
   > @johannes-nivus with your role (credentials) can you see the button?
   > ![image](https://user-images.githubusercontent.com/1945821/77089892-a4a46d80-69c3-11ea-8806-137c5cb39d14.png)
   > 
   > I will add him.....
   
   Merged an hour ago.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services