[GitHub] [commons-lang] greatmastermario commented on a diff in pull request #786: Lang-1657: Diff Result Type Constraint

["greatmastermario (via GitHub)" <gi...@apache.org>]

greatmastermario commented on code in PR #786:
URL: https://github.com/apache/commons-lang/pull/786#discussion_r1265397528


##########
src/test/java/org/apache/commons/lang3/builder/DiffBuilderTest.java:
##########
@@ -495,4 +519,16 @@ public void testTriviallyEqualTestEnabled() {
         assertThat(explicitTestAndEqual.build().getNumberOfDiffs(), equalToZero);
     }
 
+    @Test
+    public void testNestedDiffable() {

Review Comment:
   Let me validate again, but this should not be passing. The generic type T in master (did it get renamed to main? I don't see that in the repo) makes it where the passed diff needs to be the same type as the original builder. Making it ? allows other types of DiffBuilders to be passed. If this is not the behavior in master, I can rewrite the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org