You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2014/05/09 23:29:30 UTC
Review Request 21286: DRILL-679: Support create table as query (CTAS)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21286/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

Refer to JIRA description.


Diffs
-----

  common/src/main/java/org/apache/drill/common/logical/data/Writer.java PRE-CREATION 
  common/src/main/java/org/apache/drill/common/logical/data/visitors/AbstractLogicalVisitor.java 79fc34e 
  common/src/main/java/org/apache/drill/common/logical/data/visitors/LogicalVisitor.java d523541 
  contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java c4ac08c 
  distribution/src/resources/drill-override.conf a9316a9 
  distribution/src/resources/storage-plugins.json a2a9f8e 
  exec/java-exec/src/main/codegen/data/Parser.tdd 176ee79 
  exec/java-exec/src/main/codegen/includes/parserImpls.ftl 5b6e2b5 
  exec/java-exec/src/main/codegen/templates/AbstractRecordWriter.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/RecordValueAccessor.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/RecordWriter.java PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/StringOutputRecordWriter.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 9eee08d 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java abafc42 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractWriter.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 208dab9 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/Writer.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillWriterRelBase.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/CreateTableEntry.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 4defacd 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWriterRel.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DynamicDrillTable.java b830b1a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WriterPrel.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WriterPrule.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 6e9a00f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/AbstractSqlHandler.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java 116017c 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandler.java ae3960a 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandler.java b95ebc0 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/UseSchemaHandler.java fc951ed 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java a78c54f 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java 32f57b4 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java b124e1d 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java 0a666de 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java 8ba7edd 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java aa212a7 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java e3be378 
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java 92d3aff 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 5806ca7 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java 1b64257 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ad9a7db 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java 14c5ad8 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java e392fa5 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 6ade4ee 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 92a1efc 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 788e7ac 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java cbaf651 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyBatchCreator.java d79e542 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java 67502ef 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyReaderBatchCreator.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyWriter.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyWriterBatchCreator.java PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java 8bdb1ee 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java 0dbed89 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java ec6456b 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordWriter.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestWriter.java PRE-CREATION 
  exec/java-exec/src/test/resources/join/hj_exchanges.json 2ad1cb4 
  exec/java-exec/src/test/resources/storage-plugins.json 33f4fac 
  exec/java-exec/src/test/resources/writer/simple_csv_writer.json PRE-CREATION 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java ded0848 
  exec/jdbc/src/test/resources/storage-plugins.json 60efa50 

Diff: https://reviews.apache.org/r/21286/diff/


Testing
-------

Included tests in TestWriter class.


Thanks,

Venki Korukanti