You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/24 18:16:20 UTC

[jira] [Commented] (CLIMATE-488) Change Dataset.time_range to Dataset.temporal_boundaries

    [ https://issues.apache.org/jira/browse/CLIMATE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391130#comment-15391130 ] 

ASF GitHub Bot commented on CLIMATE-488:
----------------------------------------

GitHub user jarifibrahim opened a pull request:

    https://github.com/apache/climate/pull/373

    CLIMATE-488 - Change Dataset.time_range to Dataset.temporal_boundaries

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jarifibrahim/climate CLIMATE-488

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit e823b03c9ba732f42909ad7b5e5b1a41fa321824
Author: Ibrahim Jarif <ja...@gmail.com>
Date:   2016-07-24T17:49:41Z

    CLIMATE-488 - Change Dataset.time_range to Dataset.temporal_boundaries

----


> Change Dataset.time_range to Dataset.temporal_boundaries
> --------------------------------------------------------
>
>                 Key: CLIMATE-488
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-488
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>              Labels: Newcomer
>             Fix For: 1.2.0
>
>
> The current Dataset object uses time_range() to return the temporal range of the dataset. I think it would be nice to change this to temporal_boundaries() to mirror the spatial_boundaries() helper that gets the bounding box for the dataset. Thoughts? We'll probably have to update a fair amount of stuff if we change it, but I think the consistency would be worth it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)