[GitHub] StefanRRichter edited a comment on issue #7226: FLINK-11050 add lowerBound and upperBound for optimizing RocksDBMapState's entries

[GitBox <gi...@apache.org>]

StefanRRichter edited a comment on issue #7226: FLINK-11050 add lowerBound and upperBound for optimizing RocksDBMapState's entries
URL: https://github.com/apache/flink/pull/7226#issuecomment-452237612
 
 
   @Myracle I don't doubt about the usefulness or stability of the approach, the concern is that it does not generalize well beyond your use-case of integer values. Even for integer values, the semantics for upper and lower would fail if you consider negative integers, where the byte sequence for negative values is lexicographically after those of positive values. 
   You could say, that we can just have a check that minByteString <= maxByteString, but even there in a general (non-integer) case you could miss elements that you expect to see in between min and max by `Comparable` from the result of the method if it is not aligned with the serialized byte sequence.
   I am not in favor of having some new method that looks like a general API enhancement, but then only works for a subset of cases and can fail sementically (not even always with an error) for other cases.
   What I would suggest instead is thinking about a more lower level api change that generalizes well and can be used as building block to support this use case on top of it.
   
   Please also note that we could not yet update the RocksDB version, because they had a performance regression in the merge operator, but this should be fixed soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services