You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/29 01:18:54 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2752: fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…
codecov-commenter edited a comment on pull request #2752:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2752#issuecomment-630543176
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=h1) Report
> Merging [#2752](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e89f543f04872b2b7d8d3c5cd94e68cd4ddaab7e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2752 +/- ##
============================================
- Coverage 37.32% 37.19% -0.14%
+ Complexity 2563 2555 -8
============================================
Files 434 434
Lines 19983 19986 +3
Branches 2424 2424
============================================
- Hits 7459 7434 -25
- Misses 11860 11884 +24
- Partials 664 668 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ler/server/worker/processor/TaskKillProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0tpbGxQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...eduler/server/worker/runner/TaskExecuteThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza0V4ZWN1dGVUaHJlYWQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `82.60% <0.00%> (-8.70%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `71.42% <0.00%> (-6.35%)` | `14.00% <0.00%> (ø%)` | |
| [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `8.98% <0.00%> (-4.50%)` | `2.00% <0.00%> (-1.00%)` | |
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `65.30% <0.00%> (-4.09%)` | `5.00% <0.00%> (-1.00%)` | |
| [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <0.00%> (-3.51%)` | `8.00% <0.00%> (-1.00%)` | |
| [...cheduler/server/registry/ZookeeperNodeManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3JlZ2lzdHJ5L1pvb2tlZXBlck5vZGVNYW5hZ2VyLmphdmE=) | `74.72% <0.00%> (-3.30%)` | `6.00% <0.00%> (-1.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <0.00%> (-2.88%)` | `9.00% <0.00%> (-2.00%)` | |
| [...master/dispatch/executor/NettyExecutorManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9leGVjdXRvci9OZXR0eUV4ZWN1dG9yTWFuYWdlci5qYXZh) | `83.92% <0.00%> (-1.79%)` | `10.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=footer). Last update [e89f543...34a3c7b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org