[GitHub] [ozone] VarshaRaviCV commented on a diff in pull request #5328: HDDS-8648. Improving OmKeyInfo.Builder and OmDirectoryInfo.Builder usage

["VarshaRaviCV (via GitHub)" <gi...@apache.org>]

VarshaRaviCV commented on code in PR #5328:
URL: https://github.com/apache/ozone/pull/5328#discussion_r1331219283


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java:
##########
@@ -707,21 +707,21 @@ public static OmKeyInfo getOmKeyInfo(String volumeName, String bucketName,
       OmDirectoryInfo dirInfo, String keyName) {
 
     OmKeyInfo.Builder builder = new OmKeyInfo.Builder();
-    builder.setParentObjectID(dirInfo.getParentObjectID());
-    builder.setKeyName(keyName);
-    builder.setAcls(dirInfo.getAcls());
-    builder.addAllMetadata(dirInfo.getMetadata());
-    builder.setVolumeName(volumeName);
-    builder.setBucketName(bucketName);
-    builder.setCreationTime(dirInfo.getCreationTime());
-    builder.setModificationTime(dirInfo.getModificationTime());
-    builder.setObjectID(dirInfo.getObjectID());
-    builder.setUpdateID(dirInfo.getUpdateID());
-    builder.setFileName(dirInfo.getName());
-    builder.setReplicationConfig(RatisReplicationConfig
-        .getInstance(HddsProtos.ReplicationFactor.ONE));
-    builder.setOmKeyLocationInfos(Collections.singletonList(
-            new OmKeyLocationInfoGroup(0, new ArrayList<>())));
+    builder.setParentObjectID(dirInfo.getParentObjectID())
+            .setKeyName(keyName)

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org