[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12985: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java

[GitBox <gi...@apache.org>]

vamossagar12 commented on code in PR #12985:
URL: https://github.com/apache/kafka/pull/12985#discussion_r1050389751


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -159,7 +159,8 @@ public <K, V> void send(final String topic,
                     final Set<Integer> multicastPartitions = maybeMulticastPartitions.get();
                     if (multicastPartitions.isEmpty()) {
                         // If a record is not to be sent to any partition, mark it as a dropped record.
-                        log.debug("Not sending the record with key {} , value {} to any partition", key, value);
+                        log.warn("Skipping record as partitioner returned empty partitions. "

Review Comment:
   @ableegoldman my two cents , i think it's safer to not log keys and values as those can contain sensitive information at times and can lead to security issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org