[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #16735: Use single-bit for mask in dropout operator

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #16735: Use single-bit for mask in dropout operator
URL: https://github.com/apache/incubator-mxnet/pull/16735#discussion_r360740554
 
 

 ##########
 File path: src/operator/nn/dropout.cc
 ##########
 @@ -119,18 +119,12 @@ Example::
   out_shape->clear();
   out_shape->push_back(dshape);
   if (param.axes.ndim() > 0) {
-    // TODO (lnyuan): support specifying axes
-    LOG(FATAL) << "not supported yet";
-    /*
     for (int i = 0; i < param.axes.ndim(); ++i) {
       dshape[param.axes[i]] = 1;
     }
-    out_shape->push_back(dshape); */
-  } else {
-    mxnet::TShape mshape(1, static_cast<dim_t>(ceil(static_cast<double>(dshape.Size()) / 8)));
-    out_shape->push_back(mshape);
   }
-
+  mxnet::TShape mshape(1, static_cast<dim_t>(ceil(static_cast<double>(dshape.Size()) / 8)));
 
 Review comment:
   because it's faster?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services