You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by mc...@apache.org on 2013/02/04 16:46:10 UTC

svn commit: r1442155 - in /qpid/proton/trunk: cmake/Modules/ tools/ tools/cmake/ tools/cmake/Modules/

Author: mcpierce
Date: Mon Feb  4 15:46:10 2013
New Revision: 1442155

URL: http://svn.apache.org/viewvc?rev=1442155&view=rev
Log:
NO-JIRA: Moved Cmake modules to tools/cmake.

Added:
    qpid/proton/trunk/tools/
    qpid/proton/trunk/tools/cmake/
    qpid/proton/trunk/tools/cmake/Modules/
    qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/FindJava.cmake
    qpid/proton/trunk/tools/cmake/Modules/README
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/README
    qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/UseJava.cmake
    qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake
    qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake
    qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake
      - copied, changed from r1442085, qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake
Removed:
    qpid/proton/trunk/cmake/Modules/FindJava.cmake
    qpid/proton/trunk/cmake/Modules/README
    qpid/proton/trunk/cmake/Modules/UseJava.cmake
    qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake
    qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake
    qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake

Copied: qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake (from r1442085, qpid/proton/trunk/cmake/Modules/FindJava.cmake)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake&p1=qpid/proton/trunk/cmake/Modules/FindJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)

Copied: qpid/proton/trunk/tools/cmake/Modules/README (from r1442085, qpid/proton/trunk/cmake/Modules/README)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/README?p2=qpid/proton/trunk/tools/cmake/Modules/README&p1=qpid/proton/trunk/cmake/Modules/README&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)

Copied: qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake (from r1442085, qpid/proton/trunk/cmake/Modules/UseJava.cmake)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)

Copied: qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake (from r1442085, qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)

Copied: qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake (from r1442085, qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)

Copied: qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake (from r1442085, qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake)
URL: http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake&p1=qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
==============================================================================
    (empty)



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Re: svn commit: r1442155 - in /qpid/proton/trunk: cmake/Modules/ tools/ tools/cmake/ tools/cmake/Modules/

Posted by Rob Godfrey <ro...@gmail.com>.
This commit

a) broke the build for Java using cmake (since the module files could no
longer be found)
b) should have been JIRAd (and perhaps reviewed / discussed before
commiting)
c) didn't even remove the "offensive" cmake directory at the root of
proton, but just left it (and its subdirectory) empty (are you a git user
perchance?)

and thus

d) has been reverted (by me) in r1442432

-- Rob


On 4 February 2013 16:46, <mc...@apache.org> wrote:

> Author: mcpierce
> Date: Mon Feb  4 15:46:10 2013
> New Revision: 1442155
>
> URL: http://svn.apache.org/viewvc?rev=1442155&view=rev
> Log:
> NO-JIRA: Moved Cmake modules to tools/cmake.
>
> Added:
>     qpid/proton/trunk/tools/
>     qpid/proton/trunk/tools/cmake/
>     qpid/proton/trunk/tools/cmake/Modules/
>     qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/FindJava.cmake
>     qpid/proton/trunk/tools/cmake/Modules/README
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/README
>     qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/UseJava.cmake
>     qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake
>     qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake
>     qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake
>       - copied, changed from r1442085,
> qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake
> Removed:
>     qpid/proton/trunk/cmake/Modules/FindJava.cmake
>     qpid/proton/trunk/cmake/Modules/README
>     qpid/proton/trunk/cmake/Modules/UseJava.cmake
>     qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake
>     qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake
>     qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake (from
> r1442085, qpid/proton/trunk/cmake/Modules/FindJava.cmake)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/FindJava.cmake&p1=qpid/proton/trunk/cmake/Modules/FindJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/README (from r1442085,
> qpid/proton/trunk/cmake/Modules/README)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/README?p2=qpid/proton/trunk/tools/cmake/Modules/README&p1=qpid/proton/trunk/cmake/Modules/README&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake (from
> r1442085, qpid/proton/trunk/cmake/Modules/UseJava.cmake)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJava.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake
> (from r1442085, qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJavaClassFilelist.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJavaClassFilelist.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake (from
> r1442085, qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseJavaSymlinks.cmake&p1=qpid/proton/trunk/cmake/Modules/UseJavaSymlinks.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
> Copied: qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake (from
> r1442085, qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake)
> URL:
> http://svn.apache.org/viewvc/qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake?p2=qpid/proton/trunk/tools/cmake/Modules/UseProtonJava.cmake&p1=qpid/proton/trunk/cmake/Modules/UseProtonJava.cmake&r1=1442085&r2=1442155&rev=1442155&view=diff
>
> ==============================================================================
>     (empty)
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> For additional commands, e-mail: commits-help@qpid.apache.org
>
>