[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4212: Grouper Interface - Group/Summarize Metric level anomalies

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #4212: Grouper Interface - Group/Summarize Metric level anomalies
URL: https://github.com/apache/incubator-pinot/pull/4212#discussion_r284921746
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
 ##########
 @@ -225,9 +226,16 @@ YamlTranslationResult translateYaml() {
       }
     }
     Map<String, Object> dimensionWrapperProperties = buildDimensionWrapperProperties();
-    Map<String, Object> properties = buildWrapperProperties(ChildKeepingMergeWrapper.class.getName(),
-        Collections.singletonList(
-            buildWrapperProperties(DimensionWrapper.class.getName(), nestedPipelines, dimensionWrapperProperties)), this.mergerProperties);
+    Map<String, Object> properties = buildWrapperProperties(
+        ChildKeepingMergeWrapper.class.getName(),
+        Collections.singletonList(buildWrapperProperties(DimensionWrapper.class.getName(), nestedPipelines, dimensionWrapperProperties)),
+        this.mergerProperties);
+
+    List<Map<String, Object>> grouperYamls = getList(yamlConfig.get(PROP_GROUPER));
+    if (!grouperYamls.isEmpty()) {
+      properties = buildGroupWrapperProperties(grouperYamls.get(0), properties);
 
 Review comment:
   Grouper is the last layer of a metric detection pipeline. At this stage we plan to support only one grouper.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org