[GitHub] [superset] etr2460 commented on a diff in pull request #19569: fix: ensure url is a string

[GitBox <gi...@apache.org>]

etr2460 commented on code in PR #19569:
URL: https://github.com/apache/superset/pull/19569#discussion_r844163771


##########
superset/databases/utils.py:
##########
@@ -112,7 +112,9 @@ def make_url_safe(raw_url: str) -> URL:
     :param raw_url:
     :return:
     """
+
+    url = str(raw_url).strip()

Review Comment:
   if `url` might not be a string, can you fix the typing of the function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org