You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by kishankavala <gi...@git.apache.org> on 2017/04/05 05:58:51 UTC

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

Github user kishankavala commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1996#discussion_r109835294
  
    --- Diff: server/src/com/cloud/user/AccountManager.java ---
    @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria<? extends ControlledViewEntity> s
         public static final String MESSAGE_ADD_ACCOUNT_EVENT = "Message.AddAccount.Event";
     
         public static final String MESSAGE_REMOVE_ACCOUNT_EVENT = "Message.RemoveAccount.Event";
    +    public static final ConfigKey<Boolean> UseSecretKeyInResponse = new ConfigKey<Boolean>(
    +            "Advanced",
    +            Boolean.class,
    +            "use.secret.key.in.response",
    +            "true",
    --- End diff --
    
    As per discussion in PR # 1152, default value should be false. Any failing tests due to this change have to be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---