You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/04/15 03:26:46 UTC

[kudu-CR] KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor

Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2796

to review the following change.

Change subject: KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor
......................................................................

KUDU-1410 (part 3): rpc: look up the RpcMethodInfo from the reactor

This makes the reactor code look up the RpcMethodInfo associated with a call,
and moves the latency histogram collection code into the InboundCall class
instead of RpcContext. This cleans up RpcContext so now it is only responsible
for user-facing APIs and not responsible for collecting metrics.

This change may also be useful in the future if we want to start queueing calls
differently based on the particular method being invoked. We now have an easy
way for the RPC service definition to propagate up appropriate attributes
all the way to the reactor.

Change-Id: I1bed4917ca05f46c829d1733270bfba3ec20d699
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/rpc_service.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
11 files changed, 88 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/2796/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bed4917ca05f46c829d1733270bfba3ec20d699
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <mp...@apache.org>