You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/01/30 12:32:14 UTC
Review Request: CLOUDSTACK-745: Reset a VM on reboot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs
-----
api/src/com/cloud/configuration/ConfigurationService.java 48a0607
api/src/com/cloud/offering/ServiceOffering.java b13346c
api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
core/src/com/cloud/vm/UserVmVO.java 05a4bd1
core/src/com/cloud/vm/VMInstanceVO.java 13c1cf3
server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39
server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf
server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/network/security/SecurityManagerMBeanImpl.java 9328190
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java 5891056
server/test/com/cloud/vm/dao/UserVmDaoImplTest.java f07abca
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf
setup/db/create-schema.sql 174f53c
setup/db/db/schema-40to410.sql 79b7f8f
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review15840
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/ApiConstants.java
<https://reviews.apache.org/r/9157/#comment34131>
this should be - isvolatile
See how other boolean flags are used
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
<https://reviews.apache.org/r/9157/#comment34130>
Need more description as to what you mean by volatile
core/src/com/cloud/vm/VMInstanceVO.java
<https://reviews.apache.org/r/9157/#comment34133>
why do we need this in the vm instance table when its specified in svc offering
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9157/#comment34136>
You would need the same change for stop start vm as well...
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9157/#comment34134>
improve the log msg
- Nitin Mehta
On Jan. 30, 2013, 11:32 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 11:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/configuration/ConfigurationService.java 48a0607
> api/src/com/cloud/offering/ServiceOffering.java b13346c
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
> core/src/com/cloud/vm/UserVmVO.java 05a4bd1
> core/src/com/cloud/vm/VMInstanceVO.java 13c1cf3
> server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39
> server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/network/security/SecurityManagerMBeanImpl.java 9328190
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java 5891056
> server/test/com/cloud/vm/dao/UserVmDaoImplTest.java f07abca
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf
> setup/db/create-schema.sql 174f53c
> setup/db/db/schema-40to410.sql 79b7f8f
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review15841
-----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9157/#comment34135>
Why is restoreVMInternal call needed in the RebootVM command?
- Koushik Das
On Jan. 30, 2013, 11:32 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 11:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/configuration/ConfigurationService.java 48a0607
> api/src/com/cloud/offering/ServiceOffering.java b13346c
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
> core/src/com/cloud/vm/UserVmVO.java 05a4bd1
> core/src/com/cloud/vm/VMInstanceVO.java 13c1cf3
> server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39
> server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/network/security/SecurityManagerMBeanImpl.java 9328190
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java 5891056
> server/test/com/cloud/vm/dao/UserVmDaoImplTest.java f07abca
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf
> setup/db/create-schema.sql 174f53c
> setup/db/db/schema-40to410.sql 79b7f8f
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review16636
-----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/9157/#comment35308>
Move this logic to Cmd class itself.
server/src/com/cloud/migration/ServiceOffering21VO.java
<https://reviews.apache.org/r/9157/#comment35309>
When is file getting used. What scenario?
server/src/com/cloud/service/ServiceOfferingVO.java
<https://reviews.apache.org/r/9157/#comment35310>
Fix tab/spacing
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9157/#comment35311>
Why do you need vmId instead if the VM object itself as it has already been fetched in rebbotVM and restoreVM methods
setup/db/db/schema-40to410.sql
<https://reviews.apache.org/r/9157/#comment35306>
Fix is not going to 4.1 so this file shouldn't be changed. This should be moved to something like 41to42.sql
- Koushik Das
On Feb. 6, 2013, 2:41 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 2:41 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/offering/ServiceOffering.java 4d71589
> api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ee1e1b2
> server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 750b8b8
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2
> server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 574ce0a
> setup/db/create-schema.sql f89c885
> setup/db/db/schema-40to410.sql 6d5b262
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 9:20 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
cleared tabs/spaces. can ship now
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs (updated)
-----
api/src/com/cloud/offering/ServiceOffering.java 4d71589
api/src/org/apache/cloudstack/api/ApiConstants.java cd7d700
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ee1e1b2
server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5
server/src/com/cloud/configuration/ConfigurationManagerImpl.java b886bed
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java df97609
server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 180138a
setup/db/db/schema-410to420.sql 65add75
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review16835
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On Feb. 18, 2013, 5:57 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 5:57 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/offering/ServiceOffering.java 4d71589
> api/src/org/apache/cloudstack/api/ApiConstants.java cd7d700
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ee1e1b2
> server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 074675c
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java df97609
> server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 574ce0a
> setup/db/db/schema-410to420.sql 65add75
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
(Updated Feb. 18, 2013, 5:57 p.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
new diff with fixes
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs (updated)
-----
api/src/com/cloud/offering/ServiceOffering.java 4d71589
api/src/org/apache/cloudstack/api/ApiConstants.java cd7d700
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ee1e1b2
server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 074675c
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java df97609
server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 574ce0a
setup/db/db/schema-410to420.sql 65add75
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 2:41 p.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
uploaded the new diff with unit tests.
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs (updated)
-----
api/src/com/cloud/offering/ServiceOffering.java 4d71589
api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java ee1e1b2
server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 750b8b8
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2
server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 574ce0a
setup/db/create-schema.sql f89c885
setup/db/db/schema-40to410.sql 6d5b262
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 12:41 p.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
added Unit tests
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs (updated)
-----
api/src/com/cloud/offering/ServiceOffering.java b13346c
api/src/org/apache/cloudstack/api/ApiConstants.java f704aec
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
server/src/com/cloud/configuration/ConfigurationManager.java 09e8ac9
server/src/com/cloud/configuration/ConfigurationManagerImpl.java c8acf3b
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java a53e132
server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 17ad2e1
setup/db/create-schema.sql beb9103
setup/db/db/schema-40to410.sql 39b686e
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 11:29 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
updated the patch with fixes
Description
-------
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
This addresses bug CLOUDSTACK-745.
Diffs (updated)
-----
api/src/com/cloud/offering/ServiceOffering.java b13346c
api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf
server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a
server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
server/src/com/cloud/service/ServiceOfferingVO.java c199a86
server/src/com/cloud/vm/UserVmManagerImpl.java 5891056
server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf
setup/db/create-schema.sql 174f53c
setup/db/db/schema-40to410.sql 79b7f8f
Diff: https://reviews.apache.org/r/9157/diff/
Testing
-------
Did the manual testing locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Abhinandan Prateek <Ab...@citrix.com>.
Hari,
Do update the jira ticket with the progress and the details about the commit sent for review.
-abhi
On 05/02/13 2:01 PM, "Harikrishna Patnala" <ha...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9157/
Made the corresponding changes, but some merge conflicts occurred with the latest master, so working on that.
- Harikrishna
On February 1st, 2013, 12:41 p.m., Harikrishna Patnala wrote:
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
By Harikrishna Patnala.
Updated Feb. 1, 2013, 12:41 p.m.
Description
CLOUDSTACK-745: Reset a VM on reboot
To have a method to reset the vm on its reboot.
So on reboot, the vm's disk is discarded and creates a new root disk using the template.
The use cases for this are
-> Secure environments that need a fresh start on every boot
-> Desktops that should not retain state
Testing
Did the manual testing locally
Bugs: CLOUDSTACK-745
Diffs
* api/src/com/cloud/offering/ServiceOffering.java (b13346c)
* api/src/org/apache/cloudstack/api/ApiConstants.java (f704aec)
* api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java (54151fe)
* server/src/com/cloud/configuration/ConfigurationManager.java (09e8ac9)
* server/src/com/cloud/configuration/ConfigurationManagerImpl.java (c8acf3b)
* server/src/com/cloud/migration/ServiceOffering21VO.java (fdec30e)
* server/src/com/cloud/service/ServiceOfferingVO.java (c199a86)
* server/src/com/cloud/vm/UserVmManagerImpl.java (a53e132)
* server/test/com/cloud/vm/UserVmManagerTest.java (PRE-CREATION)
* server/test/com/cloud/vpc/MockConfigurationManagerImpl.java (17ad2e1)
* setup/db/create-schema.sql (beb9103)
* setup/db/db/schema-40to410.sql (39b686e)
View Diff<https://reviews.apache.org/r/9157/diff/>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On Jan. 30, 2013, 1:31 p.m., Koushik Das wrote:
> >
Made the corresponding changes, but some merge conflicts occurred with the latest master, so working on that.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review15839
-----------------------------------------------------------
On Feb. 1, 2013, 12:41 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 12:41 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/offering/ServiceOffering.java b13346c
> api/src/org/apache/cloudstack/api/ApiConstants.java f704aec
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
> server/src/com/cloud/configuration/ConfigurationManager.java 09e8ac9
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java c8acf3b
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java a53e132
> server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 17ad2e1
> setup/db/create-schema.sql beb9103
> setup/db/db/schema-40to410.sql 39b686e
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-745: Reset a VM on reboot
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9157/#review15839
-----------------------------------------------------------
api/src/com/cloud/configuration/ConfigurationService.java
<https://reviews.apache.org/r/9157/#comment34129>
There is no need for this file to change, revert the changes
core/src/com/cloud/vm/VMInstanceVO.java
<https://reviews.apache.org/r/9157/#comment34132>
Why is_volatile a property of the vm instance?
- Koushik Das
On Jan. 30, 2013, 11:32 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9157/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 11:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-745: Reset a VM on reboot
> To have a method to reset the vm on its reboot.
> So on reboot, the vm's disk is discarded and creates a new root disk using the template.
> The use cases for this are
> -> Secure environments that need a fresh start on every boot
> -> Desktops that should not retain state
>
>
> This addresses bug CLOUDSTACK-745.
>
>
> Diffs
> -----
>
> api/src/com/cloud/configuration/ConfigurationService.java 48a0607
> api/src/com/cloud/offering/ServiceOffering.java b13346c
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 54151fe
> core/src/com/cloud/vm/UserVmVO.java 05a4bd1
> core/src/com/cloud/vm/VMInstanceVO.java 13c1cf3
> server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39
> server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a
> server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e
> server/src/com/cloud/network/security/SecurityManagerMBeanImpl.java 9328190
> server/src/com/cloud/service/ServiceOfferingVO.java c199a86
> server/src/com/cloud/vm/UserVmManagerImpl.java 5891056
> server/test/com/cloud/vm/dao/UserVmDaoImplTest.java f07abca
> server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf
> setup/db/create-schema.sql 174f53c
> setup/db/db/schema-40to410.sql 79b7f8f
>
> Diff: https://reviews.apache.org/r/9157/diff/
>
>
> Testing
> -------
>
> Did the manual testing locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>