You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 23:27:29 UTC
[PR] [ISSUE-3855][test] Deepen MybatisPlusAlertSilenceRepositoryTest with delete result and label json restore [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3855:
URL: https://github.com/apache/rocketmq-dashboard/pull/3855
### Motivation
The existing `MybatisPlusAlertSilenceRepositoryTest` covers pagination, active-candidate SQL, recurring-schedule persistence and restore defaults. The `deleteById` outcome mapping and the label-JSON restore were untested.
### Changes
- `deleteByIdShouldDelegateAndReportAffectedRows`: a one-row delete returns true while a zero-row delete returns false, both through the mapper.
- `findAllShouldRestoreLabelJsonAsAMap`: the persisted label JSON is decoded back into a label map on read.
### Verification
```
mvn -B test -Dtest=MybatisPlusAlertSilenceRepositoryTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE-3855][test] Deepen MybatisPlusAlertSilenceRepositoryTest with delete result and label json restore [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3855: [ISSUE-3855][test] Deepen MybatisPlusAlertSilenceRepositoryTest with delete result and label json restore
URL: https://github.com/apache/rocketmq-dashboard/pull/3855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org