You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "norm (via GitHub)" <gi...@apache.org> on 2023/03/03 11:56:01 UTC

[GitHub] [airflow] norm commented on a diff in pull request #29832: Add `_on_failure_fail_dagrun` attribute for teardown tasks

norm commented on code in PR #29832:
URL: https://github.com/apache/airflow/pull/29832#discussion_r1124355379


##########
airflow/utils/task_group.py:
##########
@@ -245,6 +245,8 @@ def add(self, task: DAGNode) -> None:
         elif SetupTeardownContext.is_teardown:
             if isinstance(task, AbstractOperator):
                 setattr(task, "_is_teardown", True)
+                if getattr(SetupTeardownContext, "on_failure_fail_dagrun", False):
+                    setattr(task, "_on_failure_fail_dagrun", True)

Review Comment:
   The decorators would still be needed for non-classic operators, wouldn't they?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org