You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "liusheng (Code Review)" <ge...@cloudera.org> on 2019/12/10 08:04:27 UTC

[kudu-CR] [KUDU-3007] Add patch for crcutil to support aarch64 platform

liusheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14873


Change subject: [KUDU-3007] Add patch for crcutil to support aarch64 platform
......................................................................

[KUDU-3007] Add patch for crcutil to support aarch64 platform

This change is one of steps to make Kudu support ARM/aarch64
platform, Added a patch for the crcutil thirdparty depdency to
support building on aarch64 server.

Change-Id: I3a95504b52407d3e213ff76bf9ebcd960ae4fde3
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/crcutil-support-on-aarch64.patch
2 files changed, 97 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/14873/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a95504b52407d3e213ff76bf9ebcd960ae4fde3
Gerrit-Change-Number: 14873
Gerrit-PatchSet: 1
Gerrit-Owner: liusheng <li...@gmail.com>

[kudu-CR] [KUDU-3007] Add patch for crcutil to support aarch64 platform

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14873 )

Change subject: [KUDU-3007] Add patch for crcutil to support aarch64 platform
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/patches/crcutil-support-on-aarch64.patch
File thirdparty/patches/crcutil-support-on-aarch64.patch:

http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/patches/crcutil-support-on-aarch64.patch@7
PS1, Line 7: +if [[ "$(uname -p)" == "aarch64" ]]; then
           : +  crcutil_flags="-DCRCUTIL_USE_MM_CRC32=1 -Wall -march=armv8-a -Icode -Iexamples -Itests -O3"
           : +fi
           : +
> not only -march=armv8-a needed, the flags of '-msse2', '-mcrc32' and '-msse
Right, so you could do something like this:

  crcutil_flags="-DCRCUTIL_USE_MM_CRC32=1 -Wall -Icode -Iexamples -Itests"
  crcutil_flags="${crcutil_flags} -O3"
  if [[ "$(uname -p)" == "aarch64" ]]; then
    crcutil_flags="${crcutil_flags} -march=arvm8-a"
  elif [[ "$IS_CLANG" = "0" && "$(${CXX} -dumpversion)" > "4.4.9" ]]; then
    crcutil_flags="${crcutil_flags} -msse2 -mcrc32"
  elif [[ "$IS_CLANG" = "1" ]]; then
    crcutil_flags="${crcutil_flags} -msse2 -msse4.2"
  fi



-- 
To view, visit http://gerrit.cloudera.org:8080/14873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a95504b52407d3e213ff76bf9ebcd960ae4fde3
Gerrit-Change-Number: 14873
Gerrit-PatchSet: 3
Gerrit-Owner: liusheng <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: liusheng <li...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 18:27:44 +0000
Gerrit-HasComments: Yes