[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4205: Integrate Tungsten Fabric with CloudStack

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4205:
URL: https://github.com/apache/cloudstack/pull/4205#discussion_r596808922



##########
File path: engine/schema/src/main/java/com/cloud/network/TungstenGuestNetworkIpAddressVO.java
##########
@@ -0,0 +1,78 @@
+package com.cloud.network;

Review comment:
       don't forget license headers, the integration builds will fail on ommision.

##########
File path: plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java
##########
@@ -71,7 +71,7 @@
     private static final Logger s_logger = Logger.getLogger(TungstenGuestNetworkGuru.class);
 
     @Inject
-    NetworkOfferingServiceMapDao ntwkOfferingSrvcDao;
+    public NetworkOfferingServiceMapDao _ntwkOfferingSrvcDao;

Review comment:
       and please remove the _




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org