[trafficcontrol] branch master updated: Fix ORT Reval getting DSS when it doesn't need it (#4640)

[ne...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

neuman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new b3e8605  Fix ORT Reval getting DSS when it doesn't need it (#4640)
b3e8605 is described below

commit b3e8605e9bdcaf097372c9c5dff337b72ff0bc66
Author: Robert O Butts <ro...@users.noreply.github.com>
AuthorDate: Fri Apr 17 08:24:52 2020 -0600

    Fix ORT Reval getting DSS when it doesn't need it (#4640)
    
    This is a large scalability increase for ORT Reval mode.
    
    Reval doesn't actually need DSS. The meta needs it, but only for
    config files that aren't regex_revalidate.config.
    
    This is a big load decrease on TO, for many servers doing revals
    at once.
---
 traffic_ops/ort/atstccfg/cfgfile/cfgfile.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/traffic_ops/ort/atstccfg/cfgfile/cfgfile.go b/traffic_ops/ort/atstccfg/cfgfile/cfgfile.go
index a3f554f..ab90c9b 100644
--- a/traffic_ops/ort/atstccfg/cfgfile/cfgfile.go
+++ b/traffic_ops/ort/atstccfg/cfgfile/cfgfile.go
@@ -301,10 +301,10 @@ func GetTOData(cfg config.TCCfg) (*config.TOData, error) {
 		return nil
 	}
 
-	fs := []func() error{dssF, serversF, cgF, scopeParamsF, jobsF}
+	fs := []func() error{serversF, cgF, scopeParamsF, jobsF}
 	if !cfg.RevalOnly {
 		// skip data not needed for reval, if we're reval-only
-		fs = append([]func() error{dsrF, cacheKeyParamsF, parentConfigParamsF, capsF, dsCapsF}, fs...)
+		fs = append([]func() error{dssF, dsrF, cacheKeyParamsF, parentConfigParamsF, capsF, dsCapsF}, fs...)
 	}
 	errs := runParallel(fs)
 	return toData, util.JoinErrs(errs)