[GitHub] [superset] betodealmeida commented on a diff in pull request #24248: fix: save columns reference from sqllab save datasets flow

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #24248:
URL: https://github.com/apache/superset/pull/24248#discussion_r1210780190


##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -218,7 +220,9 @@ export const SaveDatasetModal = ({
         ...formDataWithDefaults,
         datasource: `${datasetToOverwrite.datasetid}__table`,
         ...(defaultVizType === 'table' && {
-          all_columns: datasource?.columns?.map(column => column.column_name),
+          all_columns: datasource?.columns?.map(
+            column => column.name || column.column_name,

Review Comment:
   I've asked this before, but I don't remember the answer. Why can't we standardize this? This is definitely going to cause bugs in the future, having two possible options for the attribute name.
   
   Can't we normalize the schema early, if they have to be stored differently, instead of normalizing it late here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org