[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3009: [Hotfix][ST-Engine] fix task operation retry timeout error

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3009:
URL: https://github.com/apache/incubator-seatunnel/pull/3009#discussion_r989702097


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -172,6 +175,21 @@ public TaskExecutionService getTaskExecutionService() {
         return taskExecutionService;
     }
 
+    /**
+     * return whether task is end
+     * @param taskGroupLocation taskGroupLocation
+     * @return
+     */
+    public boolean taskIsEnded(@NonNull TaskGroupLocation taskGroupLocation) {
+        IMap<Object, Object> runningJobState = nodeEngine.getHazelcastInstance().getMap("runningJobState");

Review Comment:
   > Unified management of mmap keywords? Define constants or util methods
   
   Ok, I will do it in next pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org