You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/01/04 06:59:23 UTC

Review Request: SRX and F5 in Inline mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/
-----------------------------------------------------------

Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.


Description
-------

Documentation for SRX and F5 in Inline mode.


Diffs
-----

  docs/en-US/external-guest-firewall-integration.xml 0b34dca 
  docs/en-US/external-guest-lb-integration.xml 5760f95 
  docs/en-US/hardware-firewall.xml df0568a 
  docs/en-US/images/add-netscaler.png PRE-CREATION 
  docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
  docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
  docs/en-US/lb-services.xml PRE-CREATION 
  docs/en-US/management-server-lb.xml 85a8622 
  docs/en-US/network-setup.xml ceee190 

Diff: https://reviews.apache.org/r/8812/diff/


Testing
-------

Tested publican. Build without errors. Patch applies cleanly


Thanks,

Radhika PC

Re: Review Request: SRX and F5 in Inline mode

Posted by Radhika PC <ra...@citrix.com>.

> On Jan. 6, 2013, 7:14 p.m., Chris Sears wrote:
> > docs/en-US/management-server-lb.xml, line 23
> > <https://reviews.apache.org/r/8812/diff/1/?file=244682#file244682line23>
> >
> >     Should this be "CloudPlatform" or "&PRODUCT;" ?

Thank you for the review. I am attaching a new patch.


- Radhika


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15105
-----------------------------------------------------------


On Jan. 4, 2013, 5:59 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:59 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Chris Sears <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15105
-----------------------------------------------------------



docs/en-US/management-server-lb.xml
<https://reviews.apache.org/r/8812/#comment32695>

    Should this be "CloudPlatform" or "&PRODUCT;" ?


- Chris Sears


On Jan. 4, 2013, 5:59 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:59 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Radhika PC <ra...@citrix.com>.

> On Jan. 11, 2013, 6:56 a.m., Jessica Tomechak wrote:
> > docs/en-US/management-server-lb.xml, line 23
> > <https://reviews.apache.org/r/8812/diff/2/?file=245809#file245809line23>
> >
> >     Will this CloudPlatform be committed, or will &PRODUCT; be committed?

fixed


- Radhika


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15259
-----------------------------------------------------------


On Jan. 11, 2013, 9:40 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 9:40 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Jessica Tomechak <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15259
-----------------------------------------------------------

Ship it!


The code for this feature has been committed (see CLOUDSTACK-306) so the documentation should also be committed. As long as the one item noted on &PRODUCT; has been taken care of, then this looks OK.


docs/en-US/management-server-lb.xml
<https://reviews.apache.org/r/8812/#comment32932>

    Will this CloudPlatform be committed, or will &PRODUCT; be committed?


- Jessica Tomechak


On Jan. 9, 2013, 8:44 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 8:44 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15270
-----------------------------------------------------------


Reviewed and verified that the patch applied cleanly without any errors . Pushed the patch to asf/master .
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/106730cc
Please mark the ticket as Submitted .
Thanks !

- Pranav Saxena


On Jan. 11, 2013, 9:41 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 9:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Jessica Tomechak <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/#review15267
-----------------------------------------------------------

Ship it!


Ship It!

- Jessica Tomechak


On Jan. 11, 2013, 9:41 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8812/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 9:41 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.
> 
> 
> Description
> -------
> 
> Documentation for SRX and F5 in Inline mode.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/external-guest-firewall-integration.xml 0b34dca 
>   docs/en-US/external-guest-lb-integration.xml 5760f95 
>   docs/en-US/hardware-firewall.xml df0568a 
>   docs/en-US/images/add-netscaler.png PRE-CREATION 
>   docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
>   docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
>   docs/en-US/lb-services.xml PRE-CREATION 
>   docs/en-US/management-server-lb.xml 85a8622 
>   docs/en-US/network-setup.xml ceee190 
> 
> Diff: https://reviews.apache.org/r/8812/diff/
> 
> 
> Testing
> -------
> 
> Tested publican. Build without errors. Patch applies cleanly
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request: SRX and F5 in Inline mode

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/
-----------------------------------------------------------

(Updated Jan. 11, 2013, 9:41 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.


Description
-------

Documentation for SRX and F5 in Inline mode.


Diffs
-----

  docs/en-US/external-guest-firewall-integration.xml 0b34dca 
  docs/en-US/external-guest-lb-integration.xml 5760f95 
  docs/en-US/hardware-firewall.xml df0568a 
  docs/en-US/images/add-netscaler.png PRE-CREATION 
  docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
  docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
  docs/en-US/lb-services.xml PRE-CREATION 
  docs/en-US/management-server-lb.xml 85a8622 
  docs/en-US/network-setup.xml ceee190 

Diff: https://reviews.apache.org/r/8812/diff/


Testing
-------

Tested publican. Build without errors. Patch applies cleanly


Thanks,

Radhika PC

Re: Review Request: SRX and F5 in Inline mode

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/
-----------------------------------------------------------

(Updated Jan. 11, 2013, 9:40 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.


Changes
-------

Addressed the issue mentioned in the review.


Description
-------

Documentation for SRX and F5 in Inline mode.


Diffs (updated)
-----

  docs/en-US/external-guest-firewall-integration.xml 0b34dca 
  docs/en-US/external-guest-lb-integration.xml 5760f95 
  docs/en-US/hardware-firewall.xml df0568a 
  docs/en-US/images/add-netscaler.png PRE-CREATION 
  docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
  docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
  docs/en-US/lb-services.xml PRE-CREATION 
  docs/en-US/management-server-lb.xml 85a8622 
  docs/en-US/network-setup.xml ceee190 

Diff: https://reviews.apache.org/r/8812/diff/


Testing
-------

Tested publican. Build without errors. Patch applies cleanly


Thanks,

Radhika PC

Re: Review Request: SRX and F5 in Inline mode

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8812/
-----------------------------------------------------------

(Updated Jan. 9, 2013, 8:44 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, and Jessica Tomechak.


Changes
-------

Issues are addressed. Attaching a new patch


Description
-------

Documentation for SRX and F5 in Inline mode.


Diffs (updated)
-----

  docs/en-US/external-guest-firewall-integration.xml 0b34dca 
  docs/en-US/external-guest-lb-integration.xml 5760f95 
  docs/en-US/hardware-firewall.xml df0568a 
  docs/en-US/images/add-netscaler.png PRE-CREATION 
  docs/en-US/images/parallel-inline-mode.png PRE-CREATION 
  docs/en-US/inline-config-lb-fw.xml PRE-CREATION 
  docs/en-US/lb-services.xml PRE-CREATION 
  docs/en-US/management-server-lb.xml 85a8622 
  docs/en-US/network-setup.xml ceee190 

Diff: https://reviews.apache.org/r/8812/diff/


Testing
-------

Tested publican. Build without errors. Patch applies cleanly


Thanks,

Radhika PC