You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by Ryan Ollos <ry...@wandisco.com> on 2014/01/25 01:19:47 UTC
Re: [Apache Bloodhound] #694: Translations scaffolding
On Fri, Jan 24, 2014 at 4:14 PM, Apache Bloodhound <
dev@bloodhound.apache.org> wrote:
> #694: Translations scaffolding
> ------------------------+----------------------
> Reporter: olemis | Owner: olemis
> Type: task | Status: assigned
> Priority: minor | Milestone:
> Component: trac core | Version: 0.7.0
> Resolution: | Keywords: i18n
> ------------------------+----------------------
>
> Comment (by SaintGermain):
>
> Hello Olemis !
>
> I agree that the patch can be included as it is, even if there is room for
> improvement.
>
> As for the bugs you mentionned, I suppose that without any translation .po
> /.mo files, no one will see the bugs. ;-)
>
> However I do not yet really understand how patch can or cannot be included
> (who can decide ?). So I am asking...
>
> Thanks !
>
A committer must decide. You've been invited to be a committer, so one you
complete the paperwork, then you will be able to push the patch.
Once you are a committer though, the general procedure for major changes,
and particularly for someone who is a new committer, is to post the patch
and wait a week or so for comments. If the feedback is positive and you
feel good about the patch, then you go ahead and push it.
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On 2/5/14, Saint Germain <sa...@gmail.com> wrote:
> On Wed, 5 Feb 2014 15:37:21 -0500, Olemis Lang <ol...@gmail.com>
> wrote :
>
>> On Wed, Feb 5, 2014 at 2:43 PM, Saint Germain <sa...@gmail.com>
>> wrote: [...]
>>
>> > Nevermind : it was a setup problem (something with my browser
>> > caching the .po file it seems).
>> > So it works now. I'll update all the widget headers and update the
>> > patch !
>> >
>> >
>>
>>
>> oh well ! much better
>> :)
>>
>
> Ok it is fixed !
>
> I have updated the ticket #694 with the patch against the current trunk
> and also updated my bitbucket repository.
>
> Almost everything is translated now but please check that what you have
> previously detected is working now.
>
There are still some errors , will be documented in the ticket
/me writing comment ...
> I also played a little with some strings which are not translated but
> it is a challenge !
>
[...]
>
> Perhaps somebody has a better idea ?
>
I will do something about it in a while , please follow latest changes
in patch queue branch t694_bh_i18n ...
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Wed, 5 Feb 2014 15:37:21 -0500, Olemis Lang <ol...@gmail.com>
wrote :
> On Wed, Feb 5, 2014 at 2:43 PM, Saint Germain <sa...@gmail.com>
> wrote: [...]
>
> > Nevermind : it was a setup problem (something with my browser
> > caching the .po file it seems).
> > So it works now. I'll update all the widget headers and update the
> > patch !
> >
> >
>
>
> oh well ! much better
> :)
>
Ok it is fixed !
I have updated the ticket #694 with the patch against the current trunk
and also updated my bitbucket repository.
Almost everything is translated now but please check that what you have
previously detected is working now.
I also played a little with some strings which are not translated but
it is a challenge !
For instance consider the following code from
bhdashboard/widgets/templates/widget_product.html ("nobody" is currently
not extracted and so cannot be translated) :
<h4 i18n:msg="name,prefix,owner">
☆ <a href="${p.href}">$p.name ($p.prefix)</a>
<py:if test="p.owner_link">
<br />
<small>owned by
<a href="$p.owner_link">${authorinfo(p._data['owner']) if p._data['owner'] else _('(nobody)')}</a>
</small>
</py:if>
</h4>
The best I can come up with is this :
<h4>
☆ <i18n:msg params="name,prefix"><a href="${p.href}">$p.name ($p.prefix)</a></i18n:msg>
<py:if test="p.owner_link">
<br />
<small i18n:msg="owner">owned by
<py:choose test="">
<py:when test="p._data['owner']">
<a href="$p.owner_link">${authorinfo(p._data['owner'])}</a>
</py:when>
<py:otherwise>
<a href="$p.owner_link">(nobody)</a>
</py:otherwise>
</py:choose>
</small>
</py:if>
</h4>
But the extracted strings is quite ugly and non-understandable.
Perhaps somebody has a better idea ?
Regards,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On Wed, Feb 5, 2014 at 2:43 PM, Saint Germain <sa...@gmail.com> wrote:
[...]
> Nevermind : it was a setup problem (something with my browser caching
> the .po file it seems).
> So it works now. I'll update all the widget headers and update the
> patch !
>
>
oh well ! much better
:)
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Wed, 5 Feb 2014 10:56:36 +0100, Saint Germain <sa...@gmail.com>
wrote :
> On 4 February 2014 04:56, Olemis Lang <ol...@gmail.com> wrote:
> > On 2/3/14, Saint Germain <sa...@gmail.com> wrote:
> >>
> >> On Mon, 3 Feb 2014 15:26:16 -0500, Olemis Lang <ol...@gmail.com>
> >> wrote :
> >>
> >>> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com>
> >>> wrote:
> >>>
> > [...]
> >>>
> >>> > I would like to introduce this patch for the next version as it
> >>> > is quite interesting and (hopefully) doesn't introduce any
> >>> > regression.
> >>> >
> >>>
> >>> afaict , I'd be inclined to suggest committing as well well *if*
> >>> dashboard widget headers are correctly localized . All other
> >>> aspects are not critical and may be deferred until forthcoming
> >>> release .
> >>>
> >>>
> >>
> >> Do you mean the widget headers "My Tickets" and "Active Tickets"
> >> which you have begun to work on part2 ?
> >
> > Those are for product /dashboard view only ...
> >
> >> I haven't seen other missing headers as far as I can see.
> >>
> >
> > ... but we'd also have to check for global /dashboard , and resource
> > (product , milestone, ...) dashboards as well .
> >
>
> Hello !
>
> I think I found the problem.
>
> In file bloodhound_dashboard/bhdashboard/web_ui.py and in the method
> expand_widget_data from DashboardModule, the widget title must be
> marked to be translated:
> return dict([k, {'title': _(data['title']),
> instead of:
> return dict([k, {'title': data['title'],
> (and of course the strings to be translated like "Active Tickets" must
> be marked to be extracted but not yet to be translated with the
> function N_)
>
> However there is 2 problems:
> 1) Some titles are already translated when they arrive at this point
> (don't know if a double translation can cause a problem)
> 2) Translation strings are picked up in the wront .po/.mo files:
> trac/trac/locale/fr/LC_MESSAGES/messages.po
> instead of:
> bloodhound_dashboard/bhdashboard/locale/fr/LC_MESSAGES/bhdashboard.po
>
> I confirmed 2) by replacing the widget titles by entire strings found
> in Trac messages.po and they are indeed translated !
> On the contrary, and strings which can be found in bhdashboard.po is
> not translated.
> I also tried to simply:
> print _("Active Tickets")
> And it only works with strings which are in Trac messages.po
>
> So it seems that we have a translation domain problem and Bloodhound
> (or Trac) pick the incorrect .po/.mo file.
>
> Does someone has some knowledge on how this translation domain work ?
>
Nevermind : it was a setup problem (something with my browser caching
the .po file it seems).
So it works now. I'll update all the widget headers and update the
patch !
Cheers,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On Wed, Feb 5, 2014 at 4:56 AM, Saint Germain <sa...@gmail.com> wrote:
> On 4 February 2014 04:56, Olemis Lang <ol...@gmail.com> wrote:
> > On 2/3/14, Saint Germain <sa...@gmail.com> wrote:
> >> On Mon, 3 Feb 2014 15:26:16 -0500, Olemis Lang <ol...@gmail.com>
> >> wrote :
> >>
>
[...]
> >>
> >> Do you mean the widget headers "My Tickets" and "Active Tickets" which
> >> you have begun to work on part2 ?
> >
> > Those are for product /dashboard view only ...
> >
> >> I haven't seen other missing headers as far as I can see.
> >>
> >
> > ... but we'd also have to check for global /dashboard , and resource
> > (product , milestone, ...) dashboards as well .
> >
>
> Hello !
>
>
Hi !
:)
> I think I found the problem.
>
> In file bloodhound_dashboard/bhdashboard/web_ui.py and in the method
> expand_widget_data from DashboardModule, the widget title must be
> marked to be translated:
> return dict([k, {'title': _(data['title']),
> instead of:
> return dict([k, {'title': data['title'],
>
I'm not sure about what you did but in advance I do not think this is
accurate . Part of the goal of widgets is to implement them in components
distributed with other packages . The function _ in this case will be bound
to domain=bhdashboard so I'm not sure of whether this will be accurate for
widgets implemented outside dashboard plugin e.g. in plugins .
> (and of course the strings to be translated like "Active Tickets" must
> be marked to be extracted but not yet to be translated with the
> function N_)
>
>
ok
> However there is 2 problems:
> 1) Some titles are already translated when they arrive at this point
> (don't know if a double translation can cause a problem)
>
hmmm ... msg IDs are in English so , afaict , there's still a chance for
this to happen if translated text is a valid English expression also
included in the catalog ... but this is quite bizarre so most of the time
should not be a problem
2) Translation strings are picked up in the wront .po/.mo files:
> trac/trac/locale/fr/LC_MESSAGES/messages.po
> instead of:
> bloodhound_dashboard/bhdashboard/locale/fr/LC_MESSAGES/bhdashboard.po
>
really ? I see no modifications in /trac so I guess you are you talking
about run-time selection of translation ?
{{{#!sh
$ hg qapplied
t694/t694_r1534486_bloodhound_i18n.diff
t694/t694_r1554007_french.diff
t694/t694_r1551811_spanish.diff
$ hg dif -r qparent -r qtip trac/
}}}
> I confirmed 2) by replacing the widget titles by entire strings found
> in Trac messages.po and they are indeed translated !
>
oh !
> On the contrary, and strings which can be found in bhdashboard.po is
> not translated.
> I also tried to simply:
> print _("Active Tickets")
> And it only works with strings which are in Trac messages.po
>
/me pulling to take a look ... but got
{{{#!sh
$ hg pull --mq saintgermain
pulling from https://olemis@bitbucket.org/saintgermain/bloodhound-mq
searching for changes
no changes found
}}}
>
> So it seems that we have a translation domain problem and Bloodhound
> (or Trac) pick the incorrect .po/.mo file.
>
This might be related to a strange behavior I've noticed before [1]_
>
> Does someone has some knowledge on how this translation domain work ?
>
>
should forward to trac-dev , maybe better by following previous thread [1]_
.. [1] https://groups.google.com/forum/#!topic/trac-dev/akzQkqePwy8
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On 4 February 2014 04:56, Olemis Lang <ol...@gmail.com> wrote:
> On 2/3/14, Saint Germain <sa...@gmail.com> wrote:
>>
>> On Mon, 3 Feb 2014 15:26:16 -0500, Olemis Lang <ol...@gmail.com>
>> wrote :
>>
>>> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com>
>>> wrote:
>>>
> [...]
>>>
>>> > I would like to introduce this patch for the next version as it is
>>> > quite interesting and (hopefully) doesn't introduce any regression.
>>> >
>>>
>>> afaict , I'd be inclined to suggest committing as well well *if*
>>> dashboard widget headers are correctly localized . All other aspects
>>> are not critical and may be deferred until forthcoming release .
>>>
>>>
>>
>> Do you mean the widget headers "My Tickets" and "Active Tickets" which
>> you have begun to work on part2 ?
>
> Those are for product /dashboard view only ...
>
>> I haven't seen other missing headers as far as I can see.
>>
>
> ... but we'd also have to check for global /dashboard , and resource
> (product , milestone, ...) dashboards as well .
>
Hello !
I think I found the problem.
In file bloodhound_dashboard/bhdashboard/web_ui.py and in the method
expand_widget_data from DashboardModule, the widget title must be
marked to be translated:
return dict([k, {'title': _(data['title']),
instead of:
return dict([k, {'title': data['title'],
(and of course the strings to be translated like "Active Tickets" must
be marked to be extracted but not yet to be translated with the
function N_)
However there is 2 problems:
1) Some titles are already translated when they arrive at this point
(don't know if a double translation can cause a problem)
2) Translation strings are picked up in the wront .po/.mo files:
trac/trac/locale/fr/LC_MESSAGES/messages.po
instead of:
bloodhound_dashboard/bhdashboard/locale/fr/LC_MESSAGES/bhdashboard.po
I confirmed 2) by replacing the widget titles by entire strings found
in Trac messages.po and they are indeed translated !
On the contrary, and strings which can be found in bhdashboard.po is
not translated.
I also tried to simply:
print _("Active Tickets")
And it only works with strings which are in Trac messages.po
So it seems that we have a translation domain problem and Bloodhound
(or Trac) pick the incorrect .po/.mo file.
Does someone has some knowledge on how this translation domain work ?
Thanks !
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On 2/3/14, Saint Germain <sa...@gmail.com> wrote:
>
> On Mon, 3 Feb 2014 15:26:16 -0500, Olemis Lang <ol...@gmail.com>
> wrote :
>
>> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com>
>> wrote:
>>
[...]
>>
>> > I would like to introduce this patch for the next version as it is
>> > quite interesting and (hopefully) doesn't introduce any regression.
>> >
>>
>> afaict , I'd be inclined to suggest committing as well well *if*
>> dashboard widget headers are correctly localized . All other aspects
>> are not critical and may be deferred until forthcoming release .
>>
>>
>
> Do you mean the widget headers "My Tickets" and "Active Tickets" which
> you have begun to work on part2 ?
Those are for product /dashboard view only ...
> I haven't seen other missing headers as far as I can see.
>
... but we'd also have to check for global /dashboard , and resource
(product , milestone, ...) dashboards as well .
[...]
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Mon, 3 Feb 2014 15:26:16 -0500, Olemis Lang <ol...@gmail.com>
wrote :
> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com>
> wrote:
>
> > On Mon, 27 Jan 2014 23:45:58 -0500, Olemis Lang <ol...@gmail.com>
> > wrote :
> >
> > > On 1/27/14, Saint Germain <sa...@gmail.com> wrote:
> > > > On Mon, 27 Jan 2014 17:18:21 -0800, Ryan Ollos
> > > > <ry...@wandisco.com> wrote :
> > > [...]
> > > >>
> > > >> Would you kindly point me to where the latest proposed changes
> > > >> are staged?
> > > >
> > > > Hello Ryan,
> > > >
> > > > I think that Olemis bitbucket repository contains the latest
> > > > update.
> > >
> > > Yes , I guess so , please see
> > >
> > https://bitbucket.org/olemis/bloodhound-mq/src/30b1129bd3b457bacd5a97fe941599e659024452/t694/?at=t694_bh_i18n
> > >
> > > > But I haven't tested it against the trunk personally.
> > >
> > > Please take a look at the log messages
> > >
> > > > If you can wait 1-2 days, I will make sure that everything works
> > > > (well except the bugs that Olemis has reported).
> > > > Except if maybe Olemis has already tested recently ?
> > > >
> > >
> > > yes , I've been playing with the patches a bit the last few days
> > > and refreshed their contents per Gary's request . I have local
> > > modifications (patches stacked on top) but still WiP .
> > >
> > > DISCLAIMER : DO NOT APPLY
> > > t694_r1554007_bloodhound_i18n.part2.diff
> > >
> > > it's still unstable .
> > >
> >
> > I have uploaded to ticket #694 a patch against the current revision
> > of Bloodhound trunk (bloodhound_i18n_r1562687.diff).
> >
> >
> >
> [...]
>
> good !
> :)
>
>
> > May I ask the mailing-list to perform a review of this patch ?
> >
> >
> I'll take a look later today .
>
>
> > I would like to introduce this patch for the next version as it is
> > quite interesting and (hopefully) doesn't introduce any regression.
> >
>
> afaict , I'd be inclined to suggest committing as well well *if*
> dashboard widget headers are correctly localized . All other aspects
> are not critical and may be deferred until forthcoming release .
>
>
Do you mean the widget headers "My Tickets" and "Active Tickets" which
you have begun to work on part2 ?
I haven't seen other missing headers as far as I can see.
I'll try to have a look on this tomorrow !
Thanks,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On 2/3/14, Olemis Lang <ol...@gmail.com> wrote:
> On 2/3/14, Olemis Lang <ol...@gmail.com> wrote:
>> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com> wrote:
>>
> [...]
>>
>>> May I ask the mailing-list to perform a review of this patch ?
>>>
>>>
>> I'll take a look later today .
>>
>
Minutes ago I pushed a few change sets so as to reduce the number of
patches to three once again (and rebase on top of current /trunk) by
performing a number of patch ops . The result is as follows :
{{{#!sh
$ hg log -r qparent
changeset: 537:97281de36ceb
tag: qparent
tag: svn-1563594
user: rjollos@13f79535-47bb-0310-9956-ffa450edef68
date: Sun Feb 02 12:03:04 2014 +0000
summary: 0.8dev: Make a test suite and allow modules to be executed.
$ hg qapplied
t694/t694_r1534486_bloodhound_i18n.diff
t694/t694_r1554007_french.diff
t694/t694_r1551811_spanish.diff
}}}
In the order displayed above they are meant for :
- generic changes for i18n
* including .py and .html files
* including .pot files
* ... though maybe it is convenient to move the later onto
a separate patch
- French translation only
* Previously mixed with modifications in .pot files , afaics
- Spanish translation only
@SaintGermain : Could you please try them, check them and report back
whether you notice anything weird or not ?
Thanks in advance
--
Regards,
Olemis - @olemislc
Apache(tm) Bloodhound contributor
http://issues.apache.org/bloodhound
http://blood-hound.net
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On 4 February 2014 05:24, Olemis Lang <ol...@gmail.com> wrote:
> On 2/3/14, Olemis Lang <ol...@gmail.com> wrote:
>> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com> wrote:
>>
> [...]
>>
>>> May I ask the mailing-list to perform a review of this patch ?
>>>
>>>
>> I'll take a look later today .
>>
>
> Just a question , will you eventually merge your patches in
> trac11338_language_prefix and t694_bh_i18n branches in MQ repos ? Both
> branches are about i18n so I guess merging into t694_bh_i18n actually
> makes sense .
>
trac11338_language_prefix is a patch on Trac to implement language
detection based on URL prefix (example.com/fr/... will set the default
language to french for instance).
See relevant Trac ticket here:
http://trac.edgewall.org/ticket/11338
It has non-trivial impact on the way the URL are processed and I am
not sure that this is ready yet (as far as I know, nobody looked at it
yet). Especially given that I am not used to Trac dev and my method
may not be good at all.
There may also be security issue (maybe an URL with a strange language
code) and regression issue (perhaps some language code conflict with
some Trac URL).
Anyway I thought that was a good idea to be able to link an URL
directly to a page in a specific language.
With the Multi-language support in the wiki
(http://trac.edgewall.org/ticket/1513) it would be great.
Regards,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On 2/3/14, Olemis Lang <ol...@gmail.com> wrote:
> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com> wrote:
>
[...]
>
>> May I ask the mailing-list to perform a review of this patch ?
>>
>>
> I'll take a look later today .
>
Just a question , will you eventually merge your patches in
trac11338_language_prefix and t694_bh_i18n branches in MQ repos ? Both
branches are about i18n so I guess merging into t694_bh_i18n actually
makes sense .
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <sa...@gmail.com> wrote:
> On Mon, 27 Jan 2014 23:45:58 -0500, Olemis Lang <ol...@gmail.com>
> wrote :
>
> > On 1/27/14, Saint Germain <sa...@gmail.com> wrote:
> > > On Mon, 27 Jan 2014 17:18:21 -0800, Ryan Ollos
> > > <ry...@wandisco.com> wrote :
> > [...]
> > >>
> > >> Would you kindly point me to where the latest proposed changes are
> > >> staged?
> > >
> > > Hello Ryan,
> > >
> > > I think that Olemis bitbucket repository contains the latest update.
> >
> > Yes , I guess so , please see
> >
> https://bitbucket.org/olemis/bloodhound-mq/src/30b1129bd3b457bacd5a97fe941599e659024452/t694/?at=t694_bh_i18n
> >
> > > But I haven't tested it against the trunk personally.
> >
> > Please take a look at the log messages
> >
> > > If you can wait 1-2 days, I will make sure that everything works
> > > (well except the bugs that Olemis has reported).
> > > Except if maybe Olemis has already tested recently ?
> > >
> >
> > yes , I've been playing with the patches a bit the last few days and
> > refreshed their contents per Gary's request . I have local
> > modifications (patches stacked on top) but still WiP .
> >
> > DISCLAIMER : DO NOT APPLY
> > t694_r1554007_bloodhound_i18n.part2.diff
> >
> > it's still unstable .
> >
>
> I have uploaded to ticket #694 a patch against the current revision of
> Bloodhound trunk (bloodhound_i18n_r1562687.diff).
>
>
>
[...]
good !
:)
> May I ask the mailing-list to perform a review of this patch ?
>
>
I'll take a look later today .
> I would like to introduce this patch for the next version as it is
> quite interesting and (hopefully) doesn't introduce any regression.
>
afaict , I'd be inclined to suggest committing as well well *if* dashboard
widget headers are correctly localized . All other aspects are not critical
and may be deferred until forthcoming release .
--
Regards,
Olemis - @olemislc
Apache(tm) Bloodhound contributor
http://issues.apache.org/bloodhound
http://blood-hound.net
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Mon, 27 Jan 2014 23:45:58 -0500, Olemis Lang <ol...@gmail.com>
wrote :
> On 1/27/14, Saint Germain <sa...@gmail.com> wrote:
> > On Mon, 27 Jan 2014 17:18:21 -0800, Ryan Ollos
> > <ry...@wandisco.com> wrote :
> [...]
> >>
> >> Would you kindly point me to where the latest proposed changes are
> >> staged?
> >
> > Hello Ryan,
> >
> > I think that Olemis bitbucket repository contains the latest update.
>
> Yes , I guess so , please see
> https://bitbucket.org/olemis/bloodhound-mq/src/30b1129bd3b457bacd5a97fe941599e659024452/t694/?at=t694_bh_i18n
>
> > But I haven't tested it against the trunk personally.
>
> Please take a look at the log messages
>
> > If you can wait 1-2 days, I will make sure that everything works
> > (well except the bugs that Olemis has reported).
> > Except if maybe Olemis has already tested recently ?
> >
>
> yes , I've been playing with the patches a bit the last few days and
> refreshed their contents per Gary's request . I have local
> modifications (patches stacked on top) but still WiP .
>
> DISCLAIMER : DO NOT APPLY
> t694_r1554007_bloodhound_i18n.part2.diff
>
> it's still unstable .
>
I have uploaded to ticket #694 a patch against the current revision of
Bloodhound trunk (bloodhound_i18n_r1562687.diff​).
It is based on Olemis work and my work to get i18n into Bloodhound.
In the ticket I have tried to describe the current limitations and
future enhancements (mostly based on Olemis work).
May I ask the mailing-list to perform a review of this patch ?
I would like to introduce this patch for the next version as it is
quite interesting and (hopefully) doesn't introduce any regression.
Thanks in advance,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Olemis Lang <ol...@gmail.com>.
On 1/27/14, Saint Germain <sa...@gmail.com> wrote:
> On Mon, 27 Jan 2014 17:18:21 -0800, Ryan Ollos
> <ry...@wandisco.com> wrote :
[...]
>>
>> Would you kindly point me to where the latest proposed changes are
>> staged?
>
> Hello Ryan,
>
> I think that Olemis bitbucket repository contains the latest update.
Yes , I guess so , please see
https://bitbucket.org/olemis/bloodhound-mq/src/30b1129bd3b457bacd5a97fe941599e659024452/t694/?at=t694_bh_i18n
> But I haven't tested it against the trunk personally.
Please take a look at the log messages
> If you can wait 1-2 days, I will make sure that everything works (well
> except the bugs that Olemis has reported).
> Except if maybe Olemis has already tested recently ?
>
yes , I've been playing with the patches a bit the last few days and
refreshed their contents per Gary's request . I have local
modifications (patches stacked on top) but still WiP .
DISCLAIMER : DO NOT APPLY
t694_r1554007_bloodhound_i18n.part2.diff
it's still unstable .
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Mon, 27 Jan 2014 17:18:21 -0800, Ryan Ollos
<ry...@wandisco.com> wrote :
> On Fri, Jan 24, 2014 at 4:47 PM, Saint Germain <sa...@gmail.com>
> wrote:
>
> > On Fri, 24 Jan 2014 16:19:47 -0800, Ryan Ollos
> > <ry...@wandisco.com> wrote :
> >
> > > On Fri, Jan 24, 2014 at 4:14 PM, Apache Bloodhound <
> > > dev@bloodhound.apache.org> wrote:
> > >
> > > > #694: Translations scaffolding
> > > > ------------------------+----------------------
> > > > Reporter: olemis | Owner: olemis
> > > > Type: task | Status: assigned
> > > > Priority: minor | Milestone:
> > > > Component: trac core | Version: 0.7.0
> > > > Resolution: | Keywords: i18n
> > > > ------------------------+----------------------
> > > >
> > > > Comment (by SaintGermain):
> > > >
> > > > Hello Olemis !
> > > >
> > > > I agree that the patch can be included as it is, even if there
> > > > is room for improvement.
> > > >
> > > > As for the bugs you mentionned, I suppose that without any
> > > > translation .po /.mo files, no one will see the bugs. ;-)
> > > >
> > > > However I do not yet really understand how patch can or cannot
> > > > be included (who can decide ?). So I am asking...
> > > >
> > > > Thanks !
> > > >
> > >
> > > A committer must decide. You've been invited to be a committer, so
> > > one you complete the paperwork, then you will be able to push the
> > > patch.
> > >
> > > Once you are a committer though, the general procedure for major
> > > changes, and particularly for someone who is a new committer, is
> > > to post the patch and wait a week or so for comments. If the
> > > feedback is positive and you feel good about the patch, then you
> > > go ahead and push it.
> >
> > Hello Ryan,
> >
> > Ok I have done the paperwork last thursday, so as soon as I got the
> > rights I will do as you said.
> >
> > Thanks,
> >
>
> Would you kindly point me to where the latest proposed changes are
> staged?
Hello Ryan,
I think that Olemis bitbucket repository contains the latest update.
But I haven't tested it against the trunk personally.
If you can wait 1-2 days, I will make sure that everything works (well
except the bugs that Olemis has reported).
Except if maybe Olemis has already tested recently ?
Regards,
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Ryan Ollos <ry...@wandisco.com>.
On Fri, Jan 24, 2014 at 4:47 PM, Saint Germain <sa...@gmail.com> wrote:
> On Fri, 24 Jan 2014 16:19:47 -0800, Ryan Ollos
> <ry...@wandisco.com> wrote :
>
> > On Fri, Jan 24, 2014 at 4:14 PM, Apache Bloodhound <
> > dev@bloodhound.apache.org> wrote:
> >
> > > #694: Translations scaffolding
> > > ------------------------+----------------------
> > > Reporter: olemis | Owner: olemis
> > > Type: task | Status: assigned
> > > Priority: minor | Milestone:
> > > Component: trac core | Version: 0.7.0
> > > Resolution: | Keywords: i18n
> > > ------------------------+----------------------
> > >
> > > Comment (by SaintGermain):
> > >
> > > Hello Olemis !
> > >
> > > I agree that the patch can be included as it is, even if there is
> > > room for improvement.
> > >
> > > As for the bugs you mentionned, I suppose that without any
> > > translation .po /.mo files, no one will see the bugs. ;-)
> > >
> > > However I do not yet really understand how patch can or cannot be
> > > included (who can decide ?). So I am asking...
> > >
> > > Thanks !
> > >
> >
> > A committer must decide. You've been invited to be a committer, so
> > one you complete the paperwork, then you will be able to push the
> > patch.
> >
> > Once you are a committer though, the general procedure for major
> > changes, and particularly for someone who is a new committer, is to
> > post the patch and wait a week or so for comments. If the feedback is
> > positive and you feel good about the patch, then you go ahead and
> > push it.
>
> Hello Ryan,
>
> Ok I have done the paperwork last thursday, so as soon as I got the
> rights I will do as you said.
>
> Thanks,
>
Would you kindly point me to where the latest proposed changes are staged?
Re: [Apache Bloodhound] #694: Translations scaffolding
Posted by Saint Germain <sa...@gmail.com>.
On Fri, 24 Jan 2014 16:19:47 -0800, Ryan Ollos
<ry...@wandisco.com> wrote :
> On Fri, Jan 24, 2014 at 4:14 PM, Apache Bloodhound <
> dev@bloodhound.apache.org> wrote:
>
> > #694: Translations scaffolding
> > ------------------------+----------------------
> > Reporter: olemis | Owner: olemis
> > Type: task | Status: assigned
> > Priority: minor | Milestone:
> > Component: trac core | Version: 0.7.0
> > Resolution: | Keywords: i18n
> > ------------------------+----------------------
> >
> > Comment (by SaintGermain):
> >
> > Hello Olemis !
> >
> > I agree that the patch can be included as it is, even if there is
> > room for improvement.
> >
> > As for the bugs you mentionned, I suppose that without any
> > translation .po /.mo files, no one will see the bugs. ;-)
> >
> > However I do not yet really understand how patch can or cannot be
> > included (who can decide ?). So I am asking...
> >
> > Thanks !
> >
>
> A committer must decide. You've been invited to be a committer, so
> one you complete the paperwork, then you will be able to push the
> patch.
>
> Once you are a committer though, the general procedure for major
> changes, and particularly for someone who is a new committer, is to
> post the patch and wait a week or so for comments. If the feedback is
> positive and you feel good about the patch, then you go ahead and
> push it.
Hello Ryan,
Ok I have done the paperwork last thursday, so as soon as I got the
rights I will do as you said.
Thanks,