[GitHub] [iotdb] mychaow commented on a diff in pull request #6075: [To rel/0.12][IOTDB-3306] Use rpc port check to avoid starting same IoTDB twice

[GitBox <gi...@apache.org>]

mychaow commented on code in PR #6075:
URL: https://github.com/apache/iotdb/pull/6075#discussion_r885147603


##########
server/src/main/java/org/apache/iotdb/db/service/IoTDB.java:
##########
@@ -106,6 +106,10 @@ private void setUp() throws StartupException {
 
     Runtime.getRuntime().addShutdownHook(new IoTDBShutdownHook());
     setUncaughtExceptionHandler();

Review Comment:
   maybe rpc is enable, but mtree is not ready, so user send a request will call npe exception?



##########
server/src/main/java/org/apache/iotdb/db/service/IoTDB.java:
##########
@@ -106,6 +106,10 @@ private void setUp() throws StartupException {
 
     Runtime.getRuntime().addShutdownHook(new IoTDBShutdownHook());
     setUncaughtExceptionHandler();

Review Comment:
   maybe rpc is enable, but mtree is not ready, so user send a request will call npe exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org