You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2008/08/10 11:54:56 UTC
svn commit: r684436 - in
/james/postage/trunk/src/main/java/org/apache/james/postage:
jmx/JVMResourceSampler.java jmx/JVMResourceSamplerWorker.java
mail/AbstractMailFactory.java mail/DefaultMailValidator.java
user/UserList.java
Author: bago
Date: Sun Aug 10 02:54:55 2008
New Revision: 684436
URL: http://svn.apache.org/viewvc?rev=684436&view=rev
Log:
Minor code cleanup (remove unnecessary casts, declarations, imports, loggers)
Modified:
james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSampler.java
james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSamplerWorker.java
james/postage/trunk/src/main/java/org/apache/james/postage/mail/AbstractMailFactory.java
james/postage/trunk/src/main/java/org/apache/james/postage/mail/DefaultMailValidator.java
james/postage/trunk/src/main/java/org/apache/james/postage/user/UserList.java
Modified: james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSampler.java
URL: http://svn.apache.org/viewvc/james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSampler.java?rev=684436&r1=684435&r2=684436&view=diff
==============================================================================
--- james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSampler.java (original)
+++ james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSampler.java Sun Aug 10 02:54:55 2008
@@ -44,7 +44,7 @@
public static boolean isJMXAvailable() {
try {
// this class is only present, when the package _is run_ at least under Java 5
- Class jmxFactoryClass = Class.forName("javax.management.remote.JMXConnectorFactory");
+ Class.forName("javax.management.remote.JMXConnectorFactory");
} catch (ClassNotFoundException e) {
return false;
}
@@ -83,7 +83,7 @@
public void connectRemoteJamesJMXServer() throws SamplingException {
if(jvmResourceSampleWorker == null) throw new SamplingException("JSE specific features not present. (compile the project with JSE 5)");
try {
- m_connectMethod.invoke(jvmResourceSampleWorker, (Object[])VOID_ARGUMENT_LIST);
+ m_connectMethod.invoke(jvmResourceSampleWorker, VOID_ARGUMENT_LIST);
} catch (Exception e) {
throw new SamplingException("could not establish connection to remote James JMX. is James really configured for JMX and running under JSE5 or later?");
}
@@ -92,7 +92,7 @@
public void doSample() throws SamplingException {
if(jvmResourceSampleWorker == null) throw new SamplingException("JSE specific features not present. (compile the project with JSE 5)");
try {
- m_doSampleMethod.invoke(jvmResourceSampleWorker, (Object[])VOID_ARGUMENT_LIST);
+ m_doSampleMethod.invoke(jvmResourceSampleWorker, VOID_ARGUMENT_LIST);
} catch (Exception e) {
throw new SamplingException(e);
}
Modified: james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSamplerWorker.java
URL: http://svn.apache.org/viewvc/james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSamplerWorker.java?rev=684436&r1=684435&r2=684436&view=diff
==============================================================================
--- james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSamplerWorker.java (original)
+++ james/postage/trunk/src/main/java/org/apache/james/postage/jmx/JVMResourceSamplerWorker.java Sun Aug 10 02:54:55 2008
@@ -86,7 +86,6 @@
}
private void takeThreadingSample(JVMResourcesRecord jvmResourcesRecord) throws SamplingException {
- CompositeDataSupport data = null;
AttributeList attributes = getRemoteThreadingAttributeValues();
jvmResourcesRecord.setThreadCountCurrent(((Integer)getAttributeValue(attributes, "ThreadCount")).longValue());
jvmResourcesRecord.setThreadCountPeak(((Integer)getAttributeValue(attributes, "PeakThreadCount")).longValue());
Modified: james/postage/trunk/src/main/java/org/apache/james/postage/mail/AbstractMailFactory.java
URL: http://svn.apache.org/viewvc/james/postage/trunk/src/main/java/org/apache/james/postage/mail/AbstractMailFactory.java?rev=684436&r1=684435&r2=684436&view=diff
==============================================================================
--- james/postage/trunk/src/main/java/org/apache/james/postage/mail/AbstractMailFactory.java (original)
+++ james/postage/trunk/src/main/java/org/apache/james/postage/mail/AbstractMailFactory.java Sun Aug 10 02:54:55 2008
@@ -50,7 +50,7 @@
}
private static int getRandomInt() {
- return (int)(Math.random() * (double)(CHARSET.length - 1));
+ return (int)(Math.random() * (CHARSET.length - 1));
}
public static byte getRandomByte() {
@@ -109,7 +109,7 @@
abstract protected Class getValidatorClass();
protected int generateRandomPartSize(int sizeMin, int sizeMax) {
- return (int)(Math.random() * (double)(sizeMax - sizeMin)) + sizeMin;
+ return (int)(Math.random() * (sizeMax - sizeMin)) + sizeMin;
}
}
Modified: james/postage/trunk/src/main/java/org/apache/james/postage/mail/DefaultMailValidator.java
URL: http://svn.apache.org/viewvc/james/postage/trunk/src/main/java/org/apache/james/postage/mail/DefaultMailValidator.java?rev=684436&r1=684435&r2=684436&view=diff
==============================================================================
--- james/postage/trunk/src/main/java/org/apache/james/postage/mail/DefaultMailValidator.java (original)
+++ james/postage/trunk/src/main/java/org/apache/james/postage/mail/DefaultMailValidator.java Sun Aug 10 02:54:55 2008
@@ -18,21 +18,17 @@
****************************************************************/
package org.apache.james.postage.mail;
+import org.apache.james.postage.result.MailProcessingRecord;
+
import javax.mail.Message;
import javax.mail.MessagingException;
import javax.mail.internet.MimeMultipart;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-import org.apache.james.postage.result.MailProcessingRecord;
-
/**
* this validator is used together with DefaultMailFactory
*/
public class DefaultMailValidator implements MailValidator {
- private static Log log = LogFactory.getLog(DefaultMailValidator.class);
-
public boolean validate(Message message, MailProcessingRecord record) {
MimeMultipart mimeMultipart;
Modified: james/postage/trunk/src/main/java/org/apache/james/postage/user/UserList.java
URL: http://svn.apache.org/viewvc/james/postage/trunk/src/main/java/org/apache/james/postage/user/UserList.java?rev=684436&r1=684435&r2=684436&view=diff
==============================================================================
--- james/postage/trunk/src/main/java/org/apache/james/postage/user/UserList.java (original)
+++ james/postage/trunk/src/main/java/org/apache/james/postage/user/UserList.java Sun Aug 10 02:54:55 2008
@@ -74,7 +74,7 @@
public String getRandomUsername() {
if (m_users.isEmpty()) return null;
- return (String)m_users.get((int)(Math.random() * (double)(m_users.size() - 1)));
+ return (String)m_users.get((int)(Math.random() * (m_users.size() - 1)));
}
public String getEmailAddress(String username) {
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org