You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/16 22:24:54 UTC
[GitHub] [nifi] priyanka-28 opened a new pull request, #6672: NIFI-10834 Fixed Flaky Test failing with NonDex
priyanka-28 opened a new pull request, #6672:
URL: https://github.com/apache/nifi/pull/6672
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10834](https://issues.apache.org/jira/browse/NIFI-10834)
Tests under TestPutSplunkHTTP express non-deterministic behavior as the order of the query parameters in the URL changes. The fix is generating all possible permutations of the query parameter and then checking the generated permutations with the value passed in the 'Assert' function to ensure deterministic behavior.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6672: NIFI-10834 Fixed Flaky Test failing with NonDex
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6672: NIFI-10834 Fixed Flaky Test failing with NonDex
URL: https://github.com/apache/nifi/pull/6672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6672: NIFI-10834 Fixed Flaky Test failing with NonDex
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6672:
URL: https://github.com/apache/nifi/pull/6672#discussion_r1033927066
##########
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/test/java/org/apache/nifi/processors/splunk/TestPutSplunkHTTP.java:
##########
@@ -131,7 +172,7 @@ public void testHappyPathWithCustomQueryParameters() throws Exception {
// then
testRunner.assertAllFlowFilesTransferred(PutSplunkHTTP.RELATIONSHIP_SUCCESS, 1);
- assertEquals("/services/collector/raw?sourcetype=test%3Fsource%3Ftype&source=test_source", path.getValue());
+ assertTrue(returnPermuations("/services/collector/raw?sourcetype=test%3Fsource%3Ftype&source=test_source").contains(path.getValue()));
Review Comment:
```suggestion
assertTrue(path.getValue().startsWith("/services/collector/raw"));
```
##########
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/test/java/org/apache/nifi/processors/splunk/TestPutSplunkHTTP.java:
##########
@@ -163,7 +204,7 @@ public void testHappyPathWithCustomQueryParametersFromFlowFile() throws Exceptio
// then
testRunner.assertAllFlowFilesTransferred(PutSplunkHTTP.RELATIONSHIP_SUCCESS, 1);
- assertEquals("/services/collector/raw?host=test_host&index=test_index&sourcetype=test%3Fsource%3Ftype&source=test_source", path.getValue());
+ assertTrue(returnPermuations("/services/collector/raw?host=test_host&index=test_index&sourcetype=test%3Fsource%3Ftype&source=test_source").contains(path.getValue()));
Review Comment:
```suggestion
assertTrue(path.getValue().startsWith("/services/collector/raw"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] priyanka-28 commented on pull request #6672: NIFI-10834 Fixed Flaky Test failing with NonDex
Posted by GitBox <gi...@apache.org>.
priyanka-28 commented on PR #6672:
URL: https://github.com/apache/nifi/pull/6672#issuecomment-1329909312
> Thanks for the contribution @priyanka-28. Although the proposed changes provide one potential solution, the additional swap and permute methods add some complexity to the unit test class. The check for the path attribute is helpful, but it seems like it would be simpler to just check that the path starts with the expected URL path, instead of attempting to check the entire string. This would avoid the need for the complex string parsing.
Thank you for your reply! I have added the updated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org