[jira] [Resolved] (HBASE-7058) the code for handling when rs.isSplit() inside AM.nodeDeleted is dead code, should be removed

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell resolved HBASE-7058.
----------------------------------------
      Assignee:     (was: Tianying Chang)
    Resolution: Incomplete

> the code for handling when rs.isSplit() inside AM.nodeDeleted is dead code, should be removed
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7058
>                 URL: https://issues.apache.org/jira/browse/HBASE-7058
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.1
>            Reporter: Tianying Chang
>            Priority: Minor
>
> I am reading the code related to region split. I feel that this code below in AssignmentManager seems to be dead code. Because 1) I don't see any place that callls to update the regionState to be State.SPLIT. 2) for scenario when region has already been split and RS crashed, ServerShutdownHandler should have already taken care of it. 
> Am I missing something here. If not, I would suggest to remove it. 
> if (rs.isSplit()) {
> LOG.debug("Ephemeral node deleted, regionserver crashed?, " +
> "clearing from RIT; rs=" + rs);
> regionOffline(rs.getRegion());



--
This message was sent by Atlassian Jira
(v8.20.7#820007)