[GitHub] [airflow] uranusjr commented on a change in pull request #21851: add an option for run id in the ui trigger screen

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #21851:
URL: https://github.com/apache/airflow/pull/21851#discussion_r823688903



##########
File path: airflow/www/views.py
##########
@@ -1838,10 +1839,10 @@ def trigger(self, session=None):
                 form=form,
                 is_dag_run_conf_overrides_params=is_dag_run_conf_overrides_params,
             )
-
-        dr = DagRun.find(dag_id=dag_id, execution_date=execution_date, run_type=DagRunType.MANUAL)
+        # if run_id is not None, filter dag runs based on run id and ignore execution date
+        dr = DagRun.find_duplicate(dag_id=dag_id, run_id=run_id, execution_date=execution_date)
         if dr:
-            flash(f"This run_id {dr.run_id} already exists")
+            flash(f"The run_id {run_id} already exists", "error")

Review comment:
       ```suggestion
               flash(f"The run_id {dr.run_id} already exists", "error")
   ```
   
   I think this should use `dr.run_id` instead because `run_id` can be empty from the UI?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org