You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/10 22:55:51 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder

TheNeuralBit commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r942970125


##########
sdks/go/test/regression/coders/fromyaml/fromyaml.go:
##########
@@ -51,6 +51,7 @@ var unimplementedCoders = map[string]bool{
 var filteredCases = []struct{ filter, reason string }{
 	{"logical", "BEAM-9615: Support logical types"},
 	{"30ea5a25-dcd8-4cdb-abeb-5332d15ab4b9", "https://github.com/apache/beam/issues/21206: Support encoding position."},
+	{"8c97b6c5-69e5-4733-907b-26cd8edae612", "https://github.com/apache/beam/issues/22629: Support single-precision float."},

Review Comment:
   Noting there's a race with #22664. Whichever is merged later should remove this exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org