[GitHub] [hudi] nsivabalan commented on a diff in pull request #8562: [DOCS] Update HMS lock provider behavior

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #8562:
URL: https://github.com/apache/hudi/pull/8562#discussion_r1175454093


##########
website/docs/concurrency_control.md:
##########
@@ -77,17 +77,30 @@ hoodie.write.lock.zookeeper.lock_key
 hoodie.write.lock.zookeeper.base_path
 ```
 
-**`HiveMetastore`** based lock provider
+**Hive Metastore** based lock provider
 
+`HiveMetastoreBasedLockProvider` uses the underlying Hive locks to support concurrency control. Note that the default 
+Hive [lock manager](https://github.com/apache/hive/blob/954bb49da611b13e689a6922538f54306004c676/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L2935) use Zookeeper
+and in order to use that, a ZooKeeper instance must be up and running.
 ```
 hoodie.write.lock.provider=org.apache.hudi.hive.transaction.lock.HiveMetastoreBasedLockProvider
-hoodie.write.lock.hivemetastore.database
-hoodie.write.lock.hivemetastore.table
+hoodie.write.lock.hivemetastore.database=test_db
+hoodie.write.lock.hivemetastore.table=test_table
+## Zookeeper configs ##

Review Comment:
   do we expect users to set the zookeeper configs? I don't think we call out the configs https://hudi.apache.org/docs/concurrency_control 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org