mod_cache and brigade

[Estrade Matthieu <es...@ifrance.com>]

Hi,

After i did my unusable proxy patch for multiple brigade handling by 
mod_cache, i tried to patch the mod_cache.
My code is doing:

receiving one brigade
if EOS inside, cache it and cache cache->saved_brigade if not null.
if no EOS, save brigade in cache->saved_brigade
w8 for another brigade, until EOS inside.

This code is working,
I controlled the data written in the cache and his length.

But i have a bug, and i really don't understand why....
When i call manual.css (2 brigades) alone 
http://127.0.0.1/manual/style/css/manual.css:

first time, it's cached by the mod_cache and served by proxy
second time, it's served by cache


data received are the same, i did a MD5 on it !
that's why i think the code is working.

When i call http://127.0.0.1/manual which is using manual.css, the same 
as above:

first time, it's cached by mod_cache and served by proxy
second time, the manual.css is not used by the browser. (netscape US 
langage)

i sniffed the connection btw the reverse proxy and the client.
the manual.css data are sent correctly to the client, but there is a 
difference btw:

served by proxy: HTTP/1.1 and no keep alive
served by cache: HTTP/1.1 and keepalive + content-length. and age=value

the others headers_out are the same.

I will continue to search why this bug is happening.
I insert my code as attachment, sorry for the french comment inside if left.


Matthieu

Re: mod_cache and brigade

[Matthieu Estrade <me...@axiliance.com>]

Hi Paul,

No problem, i send the diff on the list
sorry, but it's the first patches i send so i discover how work in group :)
I also dunno how  to make patch and ignore indentation

Matthieu



Paul J. Reder wrote:

> Matthieu,
>
> Could you possibly provide your changes as an attached diff instead of
> the entire file. Your version of the file has changed the spacing of most
> of the file so I can't easily determine what you changed.
>
> Thanks,
>
> Paul J. Reder
>
> Matthieu Estrade wrote:
>
>> Hi again,
>>
>> Just to say when i put my mozilla/netscape in HTTP/1.0, i don't have 
>> the bug i speak about in my last mail.
>>
>> Matthieu
>>
>>
>
>

Re: mod_cache and brigade

["Paul J. Reder" <re...@remulak.net>]

Matthieu,

Could you possibly provide your changes as an attached diff instead of
the entire file. Your version of the file has changed the spacing of most
of the file so I can't easily determine what you changed.

Thanks,

Paul J. Reder

Matthieu Estrade wrote:

> Hi again,
> 
> Just to say when i put my mozilla/netscape in HTTP/1.0, i don't have the 
> bug i speak about in my last mail.
> 
> Matthieu
> 
> 


-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein

Re: mod_cache and brigade

[Matthieu Estrade <me...@axiliance.com>]

Hi again,

Just to say when i put my mozilla/netscape in HTTP/1.0, i don't have the 
bug i speak about in my last mail.

Matthieu