You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/07 18:03:19 UTC
[GitHub] [iceberg] shardulm94 opened a new pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
shardulm94 opened a new pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561
A couple of fixes went into ORC 1.6.4 which allows us to remove workarounds and ignored tests
https://issues.apache.org/jira/browse/ORC-623: ORC will now correctly skip row groups for notNull predicates
https://issues.apache.org/jira/browse/ORC-661: ORC now provides timezone agnostic daysFromEpoch, so we no longer need to use reflection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] shardulm94 commented on pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561#issuecomment-705148896
@rdblue Let me retest this
The failed tests seems unrelated and may be a flaky test
```
org.apache.iceberg.actions.TestExpireSnapshotsAction24 > dataFilesCleanupWithParallelTasks FAILED
java.lang.AssertionError: FILE_B should be deleted
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561#issuecomment-705150115
@RussellSpitzer, have you seen any failures in `TestExpireSnapshotsAction` before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561#issuecomment-707863090
Sorry I didn't come back to this issue before now. The re-test passed, so I merged this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] shardulm94 edited a comment on pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
shardulm94 edited a comment on pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561#issuecomment-705148896
@rdblue Let me retest this
The failed test seems unrelated and may be a flaky test
```
org.apache.iceberg.actions.TestExpireSnapshotsAction24 > dataFilesCleanupWithParallelTasks FAILED
java.lang.AssertionError: FILE_B should be deleted
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1561: ORC: Remove workarounds after 1.6.5 upgrade
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1561:
URL: https://github.com/apache/iceberg/pull/1561#issuecomment-705152487
I restarted the JDK 8 test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org