[GitHub] [spark] hvanhovell commented on a diff in pull request #40997: [SPARK-43321][Connect] Dataset#Joinwith

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1254927419


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -99,50 +102,51 @@ object AgnosticEncoders {
     def structField: StructField = StructField(name, enc.dataType, nullable, metadata)
   }
 
-  // This supports both Product and DefinedByConstructorParams
-  case class ProductEncoder[K](
-      override val clsTag: ClassTag[K],
-      fields: Seq[EncoderField])
-    extends AgnosticEncoder[K] {
+  // Contains a sequence of fields. The fields can be flattened to columns in a row.
+  trait FieldsEncoder[K] extends AgnosticEncoder[K] {

Review Comment:
   StructEncoder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org