[GitHub] sven-lange-last commented on issue #4082: Rename prewarmed containers

[GitBox <gi...@apache.org>]

sven-lange-last commented on issue #4082: Rename prewarmed containers
URL: https://github.com/apache/incubator-openwhisk/pull/4082#issuecomment-432992661
 
 
   Basically, the idea of renaming pre-warmed Docker action containers when they are inited makes sense. As you pointed out, a simple `docker ps -a --filter 'name=wsk*'` will give you all action containers. With your renaming proposal, all containers containing `prewarm` in their name are pre-warmed while all others are warm - ignoring error conditions for the moment.
   
   The downside of renaming is that it takes time. It will add to the latency of pre-warmed invocations, i.e. Node.js invocations will take longer. Did you run any specific performance benchmarks to understand the effects of renaming or did you compare performance test results of Travis builds?
   
   I only had a very short look at your code changes. You are adding a `rename()` operation to the ContainerProxy workflow - but it seems that you don't test whether renames are properly performed in ContainerProxy tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services